Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORM-300] add missing set #371

Merged
merged 1 commit into from
Mar 6, 2025
Merged

[ORM-300] add missing set #371

merged 1 commit into from
Mar 6, 2025

Conversation

JohJohan
Copy link
Contributor

@JohJohan JohJohan commented Mar 6, 2025

I also see that SetParametersArrayToCollectionRector uses namespace Orm30 while this should be Orm300 to be consistent same as we found for: #306 can i just update the namespace? This would be breaking for people already using this rule on its own

@TomasVotruba TomasVotruba merged commit d9be91e into rectorphp:main Mar 6, 2025
6 checks passed
@TomasVotruba
Copy link
Member

Thanks 👍

Lets keep the rule namespace, to avoid breaks for little value

@JohJohan
Copy link
Contributor Author

JohJohan commented Mar 6, 2025

Lets keep the rule namespace, to avoid breaks for little value

Okay and for a new Rule for ORM-300? (im currently working on one)

@TomasVotruba
Copy link
Member

Keep it sync, the same namespace.

What matters more, is having set enable in here:
https://github.com/rectorphp/rector-doctrine/blob/main/src/Set/SetProvider/DoctrineSetProvider.php

@JohJohan JohJohan deleted the ORM-300 branch March 6, 2025 12:47
@JohJohan
Copy link
Contributor Author

JohJohan commented Mar 6, 2025

Ah check, @TomasVotruba would you like me to add the config/sets/doctrine-orm-300.php in https://github.com/rectorphp/rector-doctrine/blob/main/src/Set/SetProvider/DoctrineSetProvider.php i see that is missing as well

@TomasVotruba
Copy link
Member

Go for it 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants