Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ORM-300] add missing set, run fixer and add CastDoctrineExprToStringRector #372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ORM-300] add missing set, run fixer and add CastDoctrineExprToStringRector #372

wants to merge 1 commit into from

Conversation

JohJohan
Copy link
Contributor

@JohJohan JohJohan commented Mar 6, 2025

Add missing set @see #371 (comment)

Run ecs fixer

And add CastDoctrineExprToStringRector this will make sure the functions are casted to string where needed now after upgrade you could get errors like: Uncaught PHP Exception TypeError: "Doctrine\ORM\Query\Expr::like(): Argument #1 ($x) must be of type string, Doctrine\ORM\Query\Expr\Func given, called in x.php on line x" at Expr.php line 459

@JohJohan JohJohan requested a review from samsonasik March 7, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik Awaiting requested review from samsonasik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohJohan @samsonasik