Shouldn't it be DoctrineSetList::DOCTRINE_ORM_219?

[mvhirsch]

As the Lexer::* consts got deprecated in v2.19 and the current naming scheme in DoctrineSetList would suggest using _219 (as _214 exists for 2.14).

Shouldn't this be renamed then? https://github.com/rectorphp/rector-doctrine/blob/b3da143634de79b24a266afc07401cfe75a2c49c/config/sets/doctrine-orm-29.php

[JohJohan]

@mvhirsch i agree to be consistent in naming it should be _219

@samsonasik is this something we can do as this would be a breaking change

[TomasVotruba]

When was the TokenType added? We don't always wait for deprecations (as sometimes they come much later and in different context), but use new features once introduced.

[JohJohan]

@TomasVotruba it was added in 2.19 see: doctrine/orm@5049b61.

I think what @mvhirsch was trying to mention is that our file is called doctrine-orm-29.php: https://github.com/rectorphp/rector-doctrine/blob/b3da143634de79b24a266afc07401cfe75a2c49c/config/sets/doctrine-orm-29.php while it should be named doctrine-orm-219.php as it is for version 2.19 and changing that would be a breaking change

[TomasVotruba]

I see.
The old constant can be kept and only deprecated, not BC change.
Can you add it?

[JohJohan]

Yes will do!

[mvhirsch]

Thank you @JohJohan , @TomasVotruba