New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ORM-219] fixes #306 use correct version number #370

Merged

TomasVotruba merged 1 commit into rectorphp:main from JohJohan:ORM-219

Mar 5, 2025

Contributor

JohJohan commented Mar 5, 2025 •

edited

Loading

fixes #306

I also fixed the test folder/files thats fine right?

I was in doubt about updating: config/sets/doctrine-orm-219.php is that okay?


          [ORM-219] fixes rectorphp#306 use correct version number

90bc0a6

Member

TomasVotruba commented Mar 5, 2025

Looks good, thank you 👍

The Doctrine sets should be used via composer-based sets anyway: https://getrector.com/documentation/composer-based-sets, so constant are not covered by BC.

Let's ship it

TomasVotruba merged commit 02ca76d into rectorphp:main

6 checks passed

JohJohan deleted the ORM-219 branch

March 5, 2025 14:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet