-
Notifications
You must be signed in to change notification settings - Fork 405
Conversation
After this we still need to:
|
@TheSavior I also removed anything that was changing flow types. This is debatable - if we're going to include them though I think we should move them all to their own sections. If you can about flow types, you'll want to read them all in one place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stuff, otherwise cleaning up nicely 👌
- Remove framesToPop from bridge ([a483f802fd](https://github.com/facebook/react-native/commit/a483f802fddfd927f2baa0d95e2b4094d452cddd) by [@motiz88](https://github.com/motiz88)) | ||
- Remove TimePickerAndroid from React Native ([dbf070c51e](https://github.com/facebook/react-native/commit/dbf070c51ecd14127a8317faa75cb661697b5a6b) by [@cpojer](https://github.com/cpojer)) | ||
- Remove scrollWithoutAnimationTo from ScrollView ([c7e89909da](https://github.com/facebook/react-native/commit/c7e89909da70ac5290f9971080eb897567db3e43) by [@TheSavior](https://github.com/TheSavior)) | ||
- Remove support for `framesToPop` ([8bc02fdd52](https://github.com/facebook/react-native/commit/8bc02fdd52124d0a24d96e4a61d7688328ef1660) [cf4d45ec2b](https://github.com/facebook/react-native/commit/cf4d45ec2bcd301be7793d5840de21ec7d02275b) [a483f802fd](https://github.com/facebook/react-native/commit/a483f802fddfd927f2baa0d95e2b4094d452cddd) by [@motiz88](https://github.com/motiz88)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented on the other PR. I don't think this is necessarily a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@motiz88 could it be breaking for error reporters e.g. Sentry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an observable change in behaviour, and if they rely on it in a very particular way, then it could conceivably require them to fix something on their end. So in that sense: Yes.
But it's more "this implementation detail changed, heads up if you've come to rely on it" which might not be the same thing as "this documented public API has gone away". Maybe I'm splitting hairs though. I also get that it's probably better to err on the side of caution.
Really good cleanup here 👍 |
Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>
Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>
* changelog for 0.62 up to rc3 * [CHANGELOG] Update after fixing commit resolving #169 * [CHANGELOG] Update for v0.62.0-rc.4 * [CHANGELOG] Sort unknowns by author * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * small tweaks to remove a couple warnings * a few more typos fixes * feedback * remove empty section * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * Update CHANGELOG.md Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> * last feedback from Jeremy * couple other tweaks * better fix for it * adding a draft for the intro * Update CHANGELOG.md Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com> * changelog: move around some misplaced commits (#174) * add more details about CLI upgrade * Address unknown changelog entries (#175) * Address unknown changelog entries * Updates from feedback * Add andorid changes back * Groom 0.62 Changelog (#176) * Groom 0.62 Changelog * Update CHANGELOG.md Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com> * Apply suggestions from code review Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com> * Add Flipper, feedback from reviews Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com> * changelog: removed duplicates and fixed inconsistent formatting (#177) * Update 0.62 description (#178) * Update 0.62 description * Apply suggestions from code review Co-Authored-By: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com> * Fix typo Co-Authored-By: Core <aukwat@gmail.com> * Remove a known issue * Update CHANGELOG.md Co-Authored-By: Michał Pierzchała <thymikee@gmail.com> Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com> Co-authored-by: Jeremy Deutsch <jeremy.e.deutsch@gmail.com> Co-authored-by: Jeremy Deutsch <jeremy.deutsch@smarkets.com> Co-authored-by: Ricky <rickhanlonii@gmail.com> Co-authored-by: Core <aukwat@gmail.com> Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Summary
This PR grooms the 0.62 changelog, removing internal items and renaming/rewording others.