Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Address unknown changelog entries #175

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Address unknown changelog entries #175

merged 4 commits into from
Mar 20, 2020

Conversation

rickhanlonii
Copy link
Contributor

@rickhanlonii rickhanlonii commented Mar 20, 2020 •
edited
Loading

I didn't attempt to clean up the messages, just categorize and delete everything internal.

@rickhanlonii
Copy link
Contributor Author

Next I'll go through the other categories and remove things that are internal only but were categorized externally.

elicwhite
elicwhite approved these changes Mar 20, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md
@@ -21,12 +21,16 @@ You can participate in the conversation around this release in [this issue](ADD)
- Remove TextInput's `inputView` prop ([1804e7cbea](https://github.com/facebook/react-native/commit/1804e7cbea707a35046118090966a54031edfae8) by [@TheSavior](https://github.com/TheSavior))
- Animated: Remove `defaultProps` Parameter ([a70987cee2](https://github.com/facebook/react-native/commit/a70987cee24bcd027b9c4a5aa85dfd6a1aab74b3) by [@yungsters](https://github.com/yungsters))
- RN: Delete `TextInput.selectionState` Prop ([2becdfd404](https://github.com/facebook/react-native/commit/2becdfd4041f7f28138ba3a61c03e17c06dc2e50) by [@yungsters](https://github.com/yungsters))
- Remove accessibilityStates property. ([7b35f427fd](https://github.com/facebook/react-native/commit/7b35f427fd66cb0f36921b992095fe5b3c14d8b9))
- Remove framesToPop from bridge ([a483f802fd](https://github.com/facebook/react-native/commit/a483f802fddfd927f2baa0d95e2b4094d452cddd) by [@motiz88](https://github.com/motiz88))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not considered internal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think framesToPop will have some kind of external implications, let's leave this with a TODO to figure out what the change is and how to message it in the changelog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @motiz88

Copy link

@motiz88 motiz88 Mar 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii This commit isn't a breaking change. I believe you mean facebook/react-native@8bc02fd (which is in the changelog btw), but that's not breaking either because React Native ships with an alternative mechanism (for DEV) already enabled and satisfactory defaults included for both existing and new apps.

I don't believe framesToPop was ever a documented API, more of a Facebookism that spread to some of our packages (like invariant). Looking at de facto external implications: Crash reporting services might see some extra stack frames we would previously filter out. That's if they weren't already doing their own thing with a custom ExceptionsManager (IIRC Sentry was the one I've seen do this). Does this meet our bar for labelling something a breaking change?

CHANGELOG.md Outdated Show resolved Hide resolved
@kelset kelset added changelog entry enhancement New feature or request labels Mar 20, 2020
@kelset kelset mentioned this pull request Mar 20, 2020
Merged
@alloy
Copy link
Member

alloy commented Mar 20, 2020 •
edited
Loading

You’re doing the changelord’s work, @rickhanlonii 🙌

@rickhanlonii rickhanlonii merged commit c376c78 into chore/062-changelog-new Mar 20, 2020
@rickhanlonii rickhanlonii deleted the rh-62-unknown branch March 20, 2020 22:55
kelset added a commit that referenced this pull request Mar 26, 2020
@kelset @alloy
@jeremy-deutsch @rickhanlonii @HelloCore @thymikee
New 0.62.0 changelog (#166)
924c19d 
* changelog for 0.62 up to rc3

* [CHANGELOG] Update after fixing commit resolving

#169

* [CHANGELOG] Update for v0.62.0-rc.4

* [CHANGELOG] Sort unknowns by author

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* small tweaks to remove a couple warnings

* a few more typos fixes

* feedback

* remove empty section

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* Update CHANGELOG.md

Co-Authored-By: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>

* last feedback from Jeremy

* couple other tweaks

* better fix for it

* adding a draft for the intro

* Update CHANGELOG.md

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

* changelog: move around some misplaced commits (#174)

* add more details about CLI upgrade

* Address unknown changelog entries (#175)

* Address unknown changelog entries

* Updates from feedback

* Add andorid changes back

* Groom 0.62 Changelog (#176)

* Groom 0.62 Changelog

* Update CHANGELOG.md

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

* Add Flipper, feedback from reviews

Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>

* changelog: removed duplicates and fixed inconsistent formatting (#177)

* Update 0.62 description (#178)

* Update 0.62 description

* Apply suggestions from code review

Co-Authored-By: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

* Fix typo

Co-Authored-By: Core <aukwat@gmail.com>

* Remove a known issue

* Update CHANGELOG.md

Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>

Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
Co-authored-by: Jeremy Deutsch <jeremy.e.deutsch@gmail.com>
Co-authored-by: Jeremy Deutsch <jeremy.deutsch@smarkets.com>
Co-authored-by: Ricky <rickhanlonii@gmail.com>
Co-authored-by: Core <aukwat@gmail.com>
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@motiz88 motiz88 motiz88 left review comments

@alloy alloy alloy approved these changes

@elicwhite elicwhite elicwhite approved these changes

Assignees
No one assigned
Labels
changelog entry enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickhanlonii @alloy @elicwhite @motiz88 @kelset