Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

New 0.62.0 changelog #166

Merged
merged 38 commits into from
Mar 26, 2020
Merged

New 0.62.0 changelog #166

merged 38 commits into from
Mar 26, 2020

Conversation

kelset
Copy link
Member

@kelset kelset commented Mar 3, 2020

Allright, this is the new version of #156 that uses the new improved script (thanks @alloy!).

As we can clearly see, now the number of changes is quite more massive than the one we saw in the previous one... which means that in the ballpack number of 1.2k commits around 60-ish percent are not FB internals.

But there are still quite a big number of "unknowns" to put in the right place... I don't have time to do it atm but I'm starting to open this as a draft PR.


RELEVANT LOGS from the command:

Unable to find differential revisions for the following commits. If these were made on the release branch only, be sure to update the CHANGELOG entries to point to the commit on the master branch after back-porting.
    https://github.com/facebook/react-native/commit/be5088401fd8e19d57adda42d275cab437448064
    https://github.com/facebook/react-native/commit/26e7d6a06211412a079af746750c5dd9edbfecbb
    https://github.com/facebook/react-native/commit/cef001713fc6384353bbcb4d45645ceee44ed1a9
    https://github.com/facebook/react-native/commit/99ef72cad73da25d76bf8177272724cfe6cece61
    https://github.com/facebook/react-native/commit/55276a9b104781b49b66938d71aac385bdd236e5

and

Unable to find differential revisions for the following commits. If these were made on the release branch only, be sure to update the CHANGELOG entries to point to the commit on the master branch after back-porting.
    https://github.com/facebook/react-native/commit/be5088401fd8e19d57adda42d275cab437448064
    https://github.com/facebook/react-native/commit/26e7d6a06211412a079af746750c5dd9edbfecbb
    https://github.com/facebook/react-native/commit/cef001713fc6384353bbcb4d45645ceee44ed1a9
    https://github.com/facebook/react-native/commit/99ef72cad73da25d76bf8177272724cfe6cece61
    https://github.com/facebook/react-native/commit/55276a9b104781b49b66938d71aac385bdd236e5

@jeremy-deutsch
Copy link
Contributor

I'd like to help sort the "unknowns". @kelset, would it be possible for you to give someone trusted (like @alloy) edit access to this branch/PR, so that you don't have to be the only person who approves suggestions/moves around the "unknowns"?

@elicwhite
Copy link
Contributor

Can we get the unknown ones grouped by user? Almost all of those are Facebook employees, so we can just ask them to write the changelog for those commits.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jeremy-deutsch
Copy link
Contributor

It looks like GitHub's having some issues (note the quoted section of the changelog):
Screenshot from 2020-03-03 11-01-39

@alloy
Copy link
Member

alloy commented Mar 3, 2020

@TheSavior As a one-off, for just this version, we can sort those sections with sort -f -t @ -k 2. E.g. on macOS, copy the entries of an unknown section and then run:

pbpaste | sort -f -t @ -k 2 | pbcopy

…and paste it back.

EDIT: I’ll do this after figuring out the issues @TheSavior identified, because running it now would just lead to even weirder sort results.

CHANGELOG.md Outdated Show resolved Hide resolved
@alloy
Copy link
Member

alloy commented Mar 3, 2020

Btw, we should probably only fix the unknown entries once we generate the changelog for the version we agree to release as stable version, right? Then people can just PR their fixed changelog entries onto this branch.

CHANGELOG.md Outdated Show resolved Hide resolved
@kelset
Copy link
Member Author

kelset commented Mar 4, 2020

re: @jeremy-deutsch

I'd like to help sort the "unknowns". @kelset, would it be possible for you to give someone trusted (like @alloy) edit access to this branch/PR, so that you don't have to be the only person who approves suggestions/moves around the "unknowns"?

Eloy has write access to this repo so he can "take over" this branch when/if he wants :)
As do all the members of the RNComm github org, since it's the default setting to have write access to all repos.

I don't think I will have time to work on the feedback here today - so if anyone is taking it over please just write a comment when they do and when they are done so that we are all aware 🤗

@alloy
Copy link
Member

alloy commented Mar 6, 2020

@TheSavior Updated based on RC4 and sorted the unknowns by author.

@elicwhite
Copy link
Contributor

Yay! Thanks

Do you think this is likely to be the one and we should get our team to start annotating the uncategorized commits? Or should we hold off?

@alloy
Copy link
Member

alloy commented Mar 7, 2020

I’d like for this to be the one, so yeah ready to get started 👍

Copy link
Contributor

@jeremy-deutsch jeremy-deutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a quick scan over the "added" section and noted some things that might not belong in there.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@kelset kelset mentioned this pull request Mar 17, 2020
6 tasks
@rickhanlonii
Copy link
Contributor

@kelset do you want to review the suggested changes and I'll take a pass after that?

@elicwhite
Copy link
Contributor

@rickhanlonii, I think there was talk of someone just making changes and committing back to this branch. Do you have access?

I imagine that is easier than flagging 100 commits as internal for someone else to remove :-)

@alloy
Copy link
Member

alloy commented Mar 18, 2020

@jeremy-deutsch Hiya! You seem interested in helping out with the CHANGELOG, which is absolutely welcome 👌

I don’t believe anybody has started on this yet (correct me if I’m wrong @TheSavior), so please feel free to make a PR into this branch. It would probably be best for now to limit changes to moving around those that are in the unknown/wrong section and leave the internal ones to FB people to resolve.

As for the folding together of details about new features such as Flipper; I generally prefer that, but will defer to the people that have been doing these releases longer than I have.

@jeremy-deutsch
Copy link
Contributor

@alloy Sounds good to me! I’ll take a look to see if anything might be better categorized, but hold off on marking anything else as internal or non-stable-RN. The big bucket of suggestion comments might not have been the perfect approach here 🙂

@alloy
Copy link
Member

alloy commented Mar 18, 2020

Ace, thanks 🙏

@kelset
Copy link
Member Author

kelset commented Mar 19, 2020

hey folks - I should have some time today so I'll tackle this in the next couple hours. @jeremy-deutsch I really want to thank you for all your feedback! And don't worry, leaving all those comments is ok - luckily now GH has some nice UX over hiding addressed comments.

I'll try to merge everything you proposed, then do another cleanup, then report back - so that you don't have to waste time re-addressing all the changes you have proposed as a PR 👍

@alloy
Copy link
Member

alloy commented Mar 20, 2020

@jeremy-deutsch To follow up on my earlier comment, if you’d like to be more actively involved in work like this, please reach out to me at eloy.de.enige@gmail.com

* Address unknown changelog entries

* Updates from feedback

* Add andorid changes back
@rickhanlonii
Copy link
Contributor

Ok all the unknowns have been categorized or removed 👍

* Groom 0.62 Changelog

* Update CHANGELOG.md

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Eloy Durán <eloy.de.enige@gmail.com>

* Add Flipper, feedback from reviews

Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
@kelset kelset marked this pull request as ready for review March 24, 2020 17:35
CHANGELOG.md Outdated

This feature release of React Native includes many changes for the platform: it has been a lot of work, so please refer to the [blog post](ADD) for overlook of the main changes - like Flipper support and the new LogBox.

As always, we’ve done our best to test this release at length, especially with this being such a large release. However, note that due to challenges caused by COVID-19 to people everywhere, we [the maintainers] may not have the bandwidth we’d like to have for quick follow-up on bugs and/or a patch release. When you run into an issue, please do try to provide a fix or a detailed ticket, but be prepared to revert to the version you were previously on to unblock yourself.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alloy just a super quick question, in this phrase

[the maintainers]

is this supposed to be a link to something or it was more like " we = the maintainers"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter 👍

@kelset
Copy link
Member Author

kelset commented Mar 24, 2020

Thanks to everyone for their comments, it looks like we are (almost!) ready to merge this.

Only two things missing are the links to the blogpost (still not up) and to the dedicated issue (still not open).

Anything else that I may be forgetting?

@jeremy-deutsch
Copy link
Contributor

jeremy-deutsch commented Mar 24, 2020

@kelset I have some formatting/consistency nits, but nothing blocking (PR here)

@kelset
Copy link
Member Author

kelset commented Mar 24, 2020

thanks @jeremy-deutsch! Merged 👍

* Update 0.62 description

* Apply suggestions from code review

Co-Authored-By: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
alloy and others added 2 commits March 26, 2020 15:41
Co-Authored-By: Core <aukwat@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
- Limit size of video uploaded from camera roll in android (< 100 MB) ([d21f695edf](https://github.com/facebook/react-native/commit/d21f695edf367166a03af4c6e9376cd498b38665))
- Remove "Reload on JS change" from RN Android ([478df155e7](https://github.com/facebook/react-native/commit/478df155e70a4ce30219adcac6f0801c4e4d10ec) by [@cpojer](https://github.com/cpojer))

#### iOS specific
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is empty, so remove?

Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants