Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] dask-cuda v0.17 #469

Merged
merged 67 commits into from
Dec 10, 2020
Merged

[RELEASE] dask-cuda v0.17 #469

merged 67 commits into from
Dec 10, 2020

Conversation

GPUtester
Copy link
Contributor

❄️ Code freeze for branch-0.17 and v0.17 release

What does this mean?

Only critical/hotfix level issues should be merged into branch-0.17 until release (merging of this PR).

What is the purpose of this PR?

  • Update documentation
  • Allow testing for the new release
  • Enable a means to merge branch-0.17 into main for the release

raydouglass and others added 30 commits October 2, 2020 10:43
[gpuCI] Auto-merge branch-0.16 to branch-0.17 [skip ci]
[gpuCI] Auto-merge branch-0.16 to branch-0.17 [skip ci]
[gpuCI] Auto-merge branch-0.16 to branch-0.17 [skip ci]
* use string for bandwidth output when using a remote cluster for cudf merge benchmark

* Fix output in CuPy benchmark tests when using scheduler address

Co-authored-by: Peter Andreas Entschev <peter@entschev.com>
Fix typo in benchmark utils
#420)

* add all to all and test

* lint

* use all-to-all and move wait_for_client in cudf merge

* make all-to-all optional

* fix all-to-all logic

* remove cleanup command and simplify all-to-all

* remove cleanup from test
[gpuCI] Auto-merge branch-0.16 to branch-0.17 [skip ci]
* add disable-rmm option

* lint

* cleanup

* ignore dask-worker-space directories

* disable reinitializing the pool when disable-rmm-pool is set.  Also, allow for setting the rmm-pool-size

* update benchmark to use disable_rmm_pool

* change default chunk size

* revert default chunksize
* Decrease data size to shorten spilling tests time

* Fix formatting
Add codecov.yml and ignore uncovered files
Do not skip DGX/TCP tests when ucp is not installed
* Allow parsing CUDA_VISIBLE_DEVICES with UUID

Add new parse_cuda_visible_device utility function to parse UUIDs

* Add test CUDA_VISIBLE_DEVICES parsing with UUID

* Move cuda_visible_devices to utils.py

* Fix formatting

* Fix parse_cuda_visible_device doc typo

Co-authored-by: Mads R. B. Kristensen <madsbk@gmail.com>
msadang and others added 21 commits November 13, 2020 08:31
Co-authored-by: Peter Andreas Entschev <peter@entschev.com>

* Initial implementing of ObjectProxy

* Added basic tests of ObjectProxy

* Implemented some more proxy attributes

* Added spilling of proxy object optional

* Re-added dask_serialize for DeviceSerialized

* Added support of __array__

* Added __sizeof__

* Added some spill_proxy tests in test_device_host_file.py

* Checking len() instead of .size()

* Added dispatch support of hash_object_dispatch and group_split_dispatch

* Added "*args, **kwargs" to dispatch of ObjectProxy

* Added dispatch of make_scalar

* Added dispatch of concat_dispatch

* meta.yaml: added pandas dependency

* meta.yaml: depend on dask (not only dask-core)

* Added jit-unspill worker option

* meta.yaml: removed pandas

* Using explicit args for the dispatch functions

* ObjectProxy._obj_pxy_serialize(): takes serializers

* serializers replaces is_serialized

* Supporting cuda serializers

* Added a lot of operators

* fixed typos

* Support and test of a proxy object of a proxy object

* test_spilling_local_cuda_cluster(): added some extra checks

* Added _obj_pxy_is_cuda_object()

* asproxy(): added subclass argument

* fixed type in test_spilling_local_cuda_cluster check

* Added test of communicating proxy objects

* Making ObjectProxy threadsafe

* renamed ObjectProxy => ProxyObject

* Never re-serialize proxy objects

* Test: setting device_memory_limit="1B" to force serialization

* test: added an explicit client shutdown

* Added some str/repr tests

* added some more checks in test_proxy_object_of_numpy

* ProxyObject: added docs

* added unproxy()

* Added ValueError when serializers isn't specified

* Style and spelling fixes

* ProxyObject.__sizeof__(): use dask.sizeof()

* Serializer: convert to tuples before comparing
* Add CPU support to CuPy transpose sum benchmark

* Add back NumPy import to CuPy transpose sum benchmark
* Add `MANIFEST.in` to include versioneer components

Some of the components of versioneer may not have been included during
packaging. To fix this we add a `MANIFEST.in` file to ensure these
pieces are included.

* Always use versioneer

Make sure that we always query versioneer for the version. It already
handles cases where the package does not live in version control (like
being installed or in a tarball).
* Drop `x.x` syntax

This has been deprecated for a while in Conda-Build and isn't strictly
needed any more. So go ahead and drop it.

* Replace `build` with `host`

Conda-Build 2 added the `host` environment for things that would be
needed to link against so as to distinguish it from `build` tools, whose
CLIs were only need (like CMake). Given this, go ahead and switch this
to `host` to match with that usage.
* update builddocs dependency requirements

* only need pandas

* add dask back
Specify `master` branch to bypass `pip` solver.

Authors:
  - John Kirkham <jakirkham@gmail.com>

Approvers:
  - Benjamin Zaitlen
  - AJ Schmidt

URL: #454
* Allow setting number of threads, defaulting to 1

* Add threads per worker tests

* Fix black/flake8 formatting
* serializing using: on_error="raise"

* Implemented _obj_pxy_get_init_args()

* Implemented __reduce__
Add note on RMM pool docs mentioning its per worker [skip ci]
Authors:
  - vfdev <vfdev.5@gmail.com>

Approvers:
  - Benjamin Zaitlen
  - Peter Andreas Entschev

URL: #463
Reverts some `setup.py` changes that are necessary for PyPI uploads.
Looks like `setup.py` expects to find `requirements.txt` in the `sdist`,
but we don't include that there. To fix that, this adds
`requirements.txt` to `MANIFEST.in` to ensure it shows up in packages.
@GPUtester GPUtester requested review from a team as code owners December 7, 2020 16:27
@codecov-io
Copy link

codecov-io commented Dec 7, 2020

Codecov Report

Merging #469 (f671407) into main (0411e3b) will increase coverage by 32.93%.
The diff coverage is 88.97%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #469       +/-   ##
===========================================
+ Coverage   56.89%   89.83%   +32.93%     
===========================================
  Files          19       15        -4     
  Lines        1443     1121      -322     
===========================================
+ Hits          821     1007      +186     
+ Misses        622      114      -508     
Impacted Files Coverage Δ
dask_cuda/cuda_worker.py 70.23% <60.00%> (-2.06%) ⬇️
dask_cuda/local_cuda_cluster.py 81.25% <85.71%> (-1.71%) ⬇️
dask_cuda/proxy_object.py 87.11% <87.11%> (ø)
dask_cuda/cli/dask_cuda_worker.py 96.82% <100.00%> (+0.05%) ⬆️
dask_cuda/device_host_file.py 98.86% <100.00%> (+0.21%) ⬆️
dask_cuda/utils.py 90.65% <100.00%> (+3.25%) ⬆️
dask_cuda/_version.py
dask_cuda/is_device_object.py 92.59% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0577fba...f671407. Read the comment docs.

@ajschmidt8 ajschmidt8 merged commit 07e2543 into main Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.