Fix versioneer #448
Merged
Fix versioneer #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the components of versioneer may not have been included during packaging. To fix this we add a `MANIFEST.in` file to ensure these pieces are included.
Make sure that we always query versioneer for the version. It already handles cases where the package does not live in version control (like being installed or in a tarball).
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #448 +/- ##
============================================
Coverage 89.86% 89.86%
============================================
Files 15 15
Lines 1095 1095
============================================
Hits 984 984
Misses 111 111 Continue to review full report at Codecov.
|
|
Thanks all! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #336
MANIFEST.into include versioneer componentssetup.pyBased on local testing this should fix the issue. Also this matches with versioneer's install instructions.
cc @pentschev @quasiben