Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip DGX/TCP tests when ucp is not installed #436

Merged
merged 3 commits into from
Nov 3, 2020

Conversation

pentschev
Copy link
Member

No description provided.

@pentschev pentschev requested a review from a team as a code owner November 2, 2020 21:53
@pentschev
Copy link
Member Author

rerun tests

@quasiben
Copy link
Member

quasiben commented Nov 3, 2020

@pentschev
Copy link
Member Author

I'm not sure yet whether there's something we need to update in distributed, but I found that reverting to pytest-asyncio=0.12.0 resolves the issues locally.

@pentschev
Copy link
Member Author

It seems like this only happened now because there was no pytest-asyncio=0.14.0 in Anaconda until 3 days ago, even though it has been released months ago: https://anaconda.org/conda-forge/pytest-asyncio/files .

@quasiben
Copy link
Member

quasiben commented Nov 3, 2020 via email

@pentschev
Copy link
Member Author

I hadn't seen that, thanks for the link @quasiben , I'll pin it in dask-cuda as well for now.

@pentschev pentschev requested a review from a team as a code owner November 3, 2020 11:45
@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #436 into branch-0.17 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.17     #436   +/-   ##
============================================
  Coverage        57.02%   57.02%           
============================================
  Files               19       19           
  Lines             1473     1473           
============================================
  Hits               840      840           
  Misses             633      633           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa37d23...9c08b53. Read the comment docs.

Copy link
Member

@quasiben quasiben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pentschev !

@quasiben quasiben merged commit b4e134d into rapidsai:branch-0.17 Nov 3, 2020
@pentschev pentschev deleted the fix-dgx-test-skips branch April 23, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants