-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not skip DGX/TCP tests when ucp is not installed #436
Conversation
rerun tests |
This and #437 are both failing within the distributed testing framework we bring in: |
I'm not sure yet whether there's something we need to update in distributed, but I found that reverting to |
It seems like this only happened now because there was no |
Yes, that makes sense:
dask/distributed#4212
…On Tue, Nov 3, 2020, 5:34 AM Peter Andreas Entschev < ***@***.***> wrote:
It seems like this only happened now because there was no
pytest-asyncio=0.14.0 in Anaconda until 3 days ago, even though it has
been released months ago:
https://anaconda.org/conda-forge/pytest-asyncio/files .
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#436 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKWW6GPZWHHYVAXWKCXXLTSN7MCPANCNFSM4TH7WFLQ>
.
|
I hadn't seen that, thanks for the link @quasiben , I'll pin it in dask-cuda as well for now. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #436 +/- ##
============================================
Coverage 57.02% 57.02%
============================================
Files 19 19
Lines 1473 1473
============================================
Hits 840 840
Misses 633 633 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pentschev !
No description provided.