Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pytest-asyncio version #4212

Merged
merged 4 commits into from
Nov 2, 2020
Merged

Pin pytest-asyncio version #4212

merged 4 commits into from
Nov 2, 2020

Conversation

jrbourbeau
Copy link
Member

Checking whether or not the Travis CI failures in #4204 are related to the changes there

@jrbourbeau
Copy link
Member Author

In its latest release, pytest-asyncio began modifying the default asyncio event_loop_policy which broke tests here as we need to explicitly set our event loop policy

asyncio.set_event_loop_policy(AnyThreadEventLoopPolicy())

There is a discussion of how to proceed on the pytest-asyncio side (xref pytest-dev/pytest-asyncio#168) but for now we should just set an upper limit on our allowed version of pytest-asycnio

@jrbourbeau
Copy link
Member Author

Tests on Windows (mostly) pass 🎉 I've been test_tls_specific fail before on master (xref https://github.com/dask/distributed/runs/1332842736#step:8:116) and opened up an issue for tracking the failure (#4215)

@jrbourbeau jrbourbeau changed the title Test CI Pin pytest-asyncio version Nov 2, 2020
@TomAugspurger
Copy link
Member

Thanks.

We'll want to backport this to 2.30.x as well once it's merged.

@jrbourbeau
Copy link
Member Author

Merging as the two test failures are known flaky tests

@jrbourbeau jrbourbeau merged commit debe1b8 into dask:master Nov 2, 2020
@jrbourbeau jrbourbeau deleted the test-ci branch November 2, 2020 23:57
jrbourbeau added a commit to TomAugspurger/distributed that referenced this pull request Nov 2, 2020
jrbourbeau added a commit that referenced this pull request Nov 3, 2020
(cherry picked from commit debe1b8)
pentschev added a commit to pentschev/integration that referenced this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants