Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UCX pinnings (to support 1.17.0) #77

Closed
pentschev opened this issue Jun 28, 2024 · 3 comments
Closed

Update UCX pinnings (to support 1.17.0) #77

pentschev opened this issue Jun 28, 2024 · 3 comments
Assignees

Comments

@pentschev
Copy link
Member

pentschev commented Jun 28, 2024

To update UCX we must change various different repositories. I hope this issue will be useful for future reference, here are the places we must update:

  1. UCX-Py: dependencies.yaml and conda/recipes/ucx-py/meta.yaml. See Increase maximum UCX runtime pin ucx-py#1051 for example;
  2. UCXX: dependencies.yaml and conda/recipes/ucxx/meta.yaml. See Increase maximum UCX runtime pin ucxx#240 for example;
  3. Integration: conda/recipes/versions.yaml. See Increase maximum UCX runtime pin to <1.18.0 integration#712 for example.
  4. ucx-wheels: update VERSION. See publish v1.17.0 ucx-wheels#10 for example.
  5. devcontainers: default version in matrix.yaml, available versions in ucx feature in features/src/ucx/devcontainer-feature.json and the respective feature version in the same file. See add UCX 1.17.0 support devcontainers#338 for example.
  • and then updating base images used in devcontainers builds for libraries that use UCX

Notice that we have two different pinnings:

  1. depends_on_ucx_build: this refers what UCX version should be used to build and must be equal the minimum version we support, for example ucx==1.15.0 means we build against version 1.15.0 and that's the minimum required version at runtime;
  2. depends_on_ucx_run: this refers what UCX versions we support running, the minimum version should match at least what's defined in depends_on_ucx_build and has no theoretical upper limit, as API/ABI should be compatible, for example ucx>=1.15.0,<1.18.
@jameslamb jameslamb changed the title Update UCX pinnings Update UCX pinnings to 1.17.0 Jul 1, 2024
@jameslamb jameslamb changed the title Update UCX pinnings to 1.17.0 Update UCX pinnings (to support 1.17.0) Jul 1, 2024
vyasr pushed a commit to rapidsai/ucx-wheels that referenced this issue Jul 1, 2024
contributes to rapidsai/build-planning#77

Adds `libucx` wheels for v1.17.0 of UCX. ([release
notes](https://github.com/openucx/ucx/releases/tag/v1.17.0))
@jameslamb
Copy link
Member

and then updating base images used in devcontainers builds for libraries that use UCX

Put up PRs here:

cuml had already been updated:

rapids-bot bot pushed a commit to rapidsai/raft that referenced this issue Jul 30, 2024
Contributes to rapidsai/build-planning#77.

Follow-up to rapidsai/devcontainers#338

Proposes updating the pip devcontainers to use v1.17.0, as part of an effort to use that version across RAPIDS.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #2401
rapids-bot bot pushed a commit to rapidsai/cuvs that referenced this issue Jul 31, 2024
Contributes to rapidsai/build-planning#77.

Follow-up to rapidsai/devcontainers#338

Proposes updating the pip devcontainers to use v1.17.0, as part of an effort to use that version across RAPIDS.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Mike Sarahan (https://github.com/msarahan)

URL: #262
divyegala pushed a commit to divyegala/cuvs that referenced this issue Aug 7, 2024
Contributes to rapidsai/build-planning#77.

Follow-up to rapidsai/devcontainers#338

Proposes updating the pip devcontainers to use v1.17.0, as part of an effort to use that version across RAPIDS.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Mike Sarahan (https://github.com/msarahan)

URL: rapidsai#262
@jameslamb
Copy link
Member

It looks to me like everything needed for this is complete. @pentschev I'm going to close this. Please do re-open it if I've misunderstood and there's still something remaining.

@jakirkham
Copy link
Member

Indeed thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants