Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase maximum UCX runtime pin #1051

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Increase maximum UCX runtime pin #1051

merged 8 commits into from
Jul 31, 2024

Conversation

pentschev
Copy link
Member

Increase maximum UCX runtime pin to support UCX up to v1.17.x, but still build against v1.15.0 until we gain confidence with newer UCX.

Additionally disable protov2 by default as CUDA async/managed memory is not yet supported and leads to poor performance.

@pentschev pentschev requested review from a team as code owners June 28, 2024 11:46
@pentschev pentschev requested a review from msarahan June 28, 2024 11:46
@pentschev pentschev added enhancement New feature or request non-breaking labels Jun 28, 2024
wence-
wence- approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe document the additional "non-standard" setting?

@pentschev pentschev mentioned this pull request Jun 28, 2024
Closed
@pentschev pentschev added improvement and removed enhancement New feature or request labels Jun 28, 2024
@pentschev
Copy link
Member Author

Thanks @wence- for the suggestion, could you please have a look if the changes from 02bc2a5 are sufficient?

@pentschev
Copy link
Member Author

I actually realized removing checks for older versions is not a good idea, we still provide support for UCX installed in the system from source and thus we cannot guarantee the installed versions are met. Therefore, @wence- please have a look at 02b148f on top of 02bc2a5 .

@pentschev
Copy link
Member Author

@wence- could you have a look at my comments above whether the changes address your suggestion satisfactorily?

@pentschev pentschev changed the base branch from branch-0.39 to branch-0.40 July 30, 2024 15:44
wence-
wence- approved these changes Jul 31, 2024
View reviewed changes
docs/source/configuration.rst Outdated Show resolved Hide resolved
@pentschev @wence-
Fix docs typos
3a673ed 
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
@pentschev
Copy link
Member Author

Thanks @wence- and @msarahan for reviews/approvals.

@pentschev
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 4622c4f into rapidsai:branch-0.40 Jul 31, 2024
39 checks passed
@pentschev pentschev mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msarahan msarahan msarahan approved these changes

@wence- wence- wence- approved these changes

Assignees
No one assigned
Labels
improvement non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pentschev @msarahan @wence-