Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate libucxx build and ucxx build #257

Merged
merged 8 commits into from
Aug 6, 2024
Merged

Separate libucxx build and ucxx build #257

merged 8 commits into from
Aug 6, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 31, 2024 •
edited
Loading

Rather than building libucxx_python.so in the libucxx build, and transferring it to the ucxx package, build it in the ucxx build.

Nothing other than the Python wheel is currently using ucxx::python, so stop exporting it and installing the headers as well.

@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change DO NOT MERGE Hold off on merging; see PR for details labels Jul 31, 2024
@bdice
Copy link
Contributor

bdice commented Aug 1, 2024 •
edited
Loading

The import test for ucxx is failing with ImportError: libucxx_python.so: cannot open shared object file: No such file or directory. It comes from here:

ucxx/conda/recipes/ucxx/meta.yaml

Lines 258 to 259 in 95f4eda

imports:
- ucxx

pentschev
pentschev requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KyleFromNVIDIA , left a few change requests.

build.sh Outdated Show resolved Hide resolved
cpp/python/CMakeLists.txt Outdated Show resolved Hide resolved
python/ucxx/CMakeLists.txt Outdated Show resolved Hide resolved
@KyleFromNVIDIA
Copy link
Contributor Author

Thanks for the review @pentschev. This PR is still very much a work in progress. I'll address whatever portions of your review are still relevant once I've actually got it working.

@KyleFromNVIDIA KyleFromNVIDIA changed the title [WIP] Separate libucxx build and ucxx build Separate libucxx build and ucxx build Aug 2, 2024
@KyleFromNVIDIA KyleFromNVIDIA removed the DO NOT MERGE Hold off on merging; see PR for details label Aug 2, 2024
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review August 2, 2024 21:27
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners August 2, 2024 21:27
bdice
bdice reviewed Aug 2, 2024
View reviewed changes
build.sh Outdated Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
cpp/python/CMakeLists.txt Show resolved Hide resolved
pentschev
pentschev reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, left a few comments/suggestions.

cpp/python/CMakeLists.txt Show resolved Hide resolved
cpp/python/CMakeLists.txt Show resolved Hide resolved
cpp/python/CMakeLists.txt Show resolved Hide resolved
cpp/python/CMakeLists.txt Show resolved Hide resolved
pentschev
pentschev approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @KyleFromNVIDIA .

jameslamb
jameslamb approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick look, I don't have any additional comments. Thanks!

@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 357b0b8 into rapidsai:branch-0.40 Aug 6, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@pentschev pentschev pentschev approved these changes

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KyleFromNVIDIA @bdice @pentschev @jameslamb