Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to remove an authorized IP range #592

Closed
2 tasks done
valaparthvi opened this issue Jul 11, 2024 · 5 comments
Closed
2 tasks done

Unable to remove an authorized IP range #592

valaparthvi opened this issue Jul 11, 2024 · 5 comments
Assignees
@mjura @valaparthvi
Labels
kind/bug Something isn't working
Milestone
v2.9.1

Comments

@valaparthvi
Copy link
Contributor

valaparthvi commented Jul 11, 2024 •
edited by kkaempf
Loading

Rancher: v2.9-3c4ccdc5bc9fde3510089153b5ad58fdbe604880-head
Dashboard: master rancher/dashboard@00e9eb2

Adding a new IP range works as expected, but removing an IP range does not work, from UI, all the buttons are active and even the operator logs indicate that an update is in progress, but when the update finishes, there appears to be no change.

Steps to reproduce:

  1. Create an AKS cluster with two authorized IP ranges.
  2. Once the cluster is active, update it to remove one of the ranges OR uncheck Authorized IP Ranges.
  3. Monitor deploy/aks-config-operator logs to ensure the update is in progress.
  4. Once the update finishes, check the config.

The removed IP range is still present in both AKSConfig and UpstreamSpec.

Notes:

  1. The cluster does not go into Updating state, is this expected?
  2. Editing an existing IP range, adds a new one.

Ref: rancher/dashboard#6879 (comment)

PR's
@valaparthvi valaparthvi mentioned this issue Jul 11, 2024
Open
@valaparthvi
Copy link
Contributor Author

@mjura @yiannistri Can this get some love?

@mjura mjura self-assigned this Jul 18, 2024
mjura added a commit to mjura/aks-operator that referenced this issue Jul 19, 2024
@mjura
Fix logic for Authorized IP ranges
32ed738 
Fix logic for updating Authorized IP ranges:
- all settings should be overwrite for AKS clusters provisioned by Rancher
- for imported clusters options should be merged with downstream cluster

Issue: rancher#592
@mjura mjura mentioned this issue Jul 19, 2024
Merged
5 tasks
@valaparthvi valaparthvi self-assigned this Jul 30, 2024
@valaparthvi
Copy link
Contributor Author

Fixed on Rancher v2.9-6e9cf233a87796ee9a96e73c096a82101fc9c2ff-head.

@valaparthvi
Copy link
Contributor Author

The issue is still persistent. The IP range was removed, but then it got re-added after a few minutes.

@valaparthvi valaparthvi reopened this Jul 31, 2024
@valaparthvi
Copy link
Contributor Author

cc: @mjura @yiannistri

@kkaempf kkaempf added this to the v2.9-Next1 milestone Aug 6, 2024
@kkaempf kkaempf added the kind/bug Something isn't working label Aug 6, 2024
@valaparthvi
Copy link
Contributor Author

Tested this again on Rancher (v2.9-0ab20e8fe6275887c52b97e94e15365f33b8afab-head); Dashboard(release-2.9 rancher/dashboard@6e45e2f), aks-operator(rancher-aks-operator:104.1.0+up1.9.1-rc.4).

FIXED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjura mjura

@valaparthvi valaparthvi

Labels
kind/bug Something isn't working
Projects
CAPI & Hosted Kubernetes providers (EKS/AKS/GKE)
Archived in project
Milestone
v2.9.1
Development

No branches or pull requests
3 participants
@kkaempf @mjura @valaparthvi