[v2.9] Fix logic for Authorized IP ranges #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix logic for updating Authorized IP ranges: - all settings should be overwrite for AKS clusters provisioned by Rancher - for imported clusters options should be merged with downstream cluster Issue: rancher#592
2 tasks
| @@ -108,14 +108,23 @@ func updateCluster(desiredCluster armcontainerservice.ManagedCluster, actualClus | |||
| } | |||
| } | |||
|
|
|||
| // If the cluster is imported, we may not have the authorized IP ranges set on the spec. | |||
There was a problem hiding this comment.
Q: is there a case where authorized IP ranges are set on the spec and if so what happens in that case?
There was a problem hiding this comment.
For imported clusters it is not possible, always this setting will be overwritten with downstream cluster
yiannistri
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix logic for updating Authorized IP ranges:
Issue: #592
What this PR does / why we need it:
Which issue(s) this PR fixes
Issue #
Special notes for your reviewer:
Checklist: