Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for Authorized IP ranges #595

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

mjura
Copy link
Contributor

@mjura mjura commented Jul 19, 2024

(cherry picked from commit 08974fc3330e57b06dba4fe574f1c9e3b1782341)

What this PR does / why we need it:

Which issue(s) this PR fixes
Issue #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

(cherry picked from commit 08974fc3330e57b06dba4fe574f1c9e3b1782341)
@mjura mjura requested a review from a team as a code owner July 19, 2024 07:16
@yiannistri yiannistri self-requested a review July 24, 2024 14:24
Copy link
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected. Nice work adding tests for edge cases 👌

@mjura mjura merged commit b1d9bbf into rancher:main Jul 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants