-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n for typst #9829
i18n for typst #9829
Conversation
I believe you that it didn't work, but we do have support for it, in
|
includes change to typst-template.typ which will need to be revisited with jgm/pandoc#9724
b4e537c
to
34619b2
Compare
Thanks @cscheid! I was able to test pandoc3 figure with
and the subfloat case case for ::: {#fig-panel layout-ncol=2}
![Marcador]({{< placeholder 200 >}}){#fig-layout-a}
![Marcador]({{< placeholder 200 >}}){#fig-layout-b}
Panels
::: IIUC the final case of ::: {#fig-panel2 layout-ncol=2}
![Marcador]({{< placeholder 200 >}})
![Marcador]({{< placeholder 200 >}})
Panels
::: But anything I put there, I get the inscrutable error
(I thought that Blocks was a list of Blocks!) I tried to debug this, but the line numbers and functions in the stack trace don't quite make sense to me. Perhaps it merits a separate issue. It renders as I would expect in HTML and I think this confirms that the supplement is unused and does not need to be localized. |
This is a really bad error message from Pandoc, and it can come up in situations where a |
Very helpful clue. Okay, I'm opening a new issue for that one as it doesn't seem like this example has worked right since 1.5.0 but it started crashing with subfloats. I think this is complete except for looking at the future impact of the fix and submitting a PR on Pandoc. That seems to require a different change to the template but I am not sure that I understand their i18n system yet. |
I've pushed the fix to #9854 to this branch, since the test here triggers that. Ok to merge? When we get a fix upstream in Pandoc we can revert to their template. |
@gordonwoodhull I don't think we should have that subfigure situation - if we're going to have supplements and numbering in that case, then they'd need to be subfloats. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit message is incorrect, this affects the parent title of a panel with non-cross-referenceable figures (that are nevertheless rendered as cross-referenced, with counter continuing in them)
Completely agree, but I think it's outside the scope of this PR. I think we have a small constellation of issues around figures without ids in Typst. Could we merge this and I'll open another issue with the numbering problem? |
Continued in #9857 |
Squashed and merged to main in d40b8ec, closing this. |
Closes #9555
Internationalization of
Loose ends on this draft
PanelLayout
in Typst? I tried the HTML Panel Layouts::: {layout = "[ [1,1] ]"}
but no surprise that didn't work.quarto-cli/src/resources/filters/layout/typst.lua
Line 141 in 301b235
abstract-title
for Typst format jgm/pandoc#9724 and see if this affects the change to the Typst template.