id-less typst figures get numbered inside other figures

[gordonwoodhull]

And wrongness of numbering ensues.

Same example as #9854

---
title: "Typst messy subnumbering"
format:
  typst:
    keep-typ: true
---


::: {#fig-panel2 layout-ncol=2}

![Placeholder](pl200.png)

![Placeholder](pl200.png)

Panels

:::

1. There should not be supplements and numbering for figures without ids
2. However, Typst has defined a figure as something that is cross-referenceable, so
3. It gets automatically upgraded on rendering
4. But it wasn't a FloatRefTarget so has_subfloats is false.

Note that plain

![Placeholder](pl200.png)

by itself also gets printed as a figure with supplement and numbering.

We seem to be stuck with that for now, unless we wanted to not use Typst figure for these cases, or number them in a void context and strip the text out in post, yuck.

So it seems we should detect this case, and transform these captioned, no-id figures as subfloats so they get lettered appropriately instead of numbered inappropriately.

[cscheid]

by itself also gets printed as a figure with supplement and numbering.

We seem to be stuck with that for now, unless we wanted to not use Typst figure for these cases, or number them in a void context and strip the text out in post, yuck.

Agreed. Just to reiterate, this is the same situation as in LaTeX. An image with a caption and without a fig- label still becomes a default float (Figure):

---
format: pdf
---

Hi.

![A caption]({{< placeholder >}})

Hi.

So it seems we should detect this case, and transform these captioned, no-id figures as subfloats so they get lettered appropriately instead of numbered inappropriately.

Exactly. Ideally we'd do the same thing in LaTeX, but I just realized that the following causes a LaTeX bug:

::: {#fig-1}

![An inner caption]({{< placeholder >}})

![An inner caption]({{< placeholder >}})

An outer caption.

:::

This causes the dreaded not in outer par mode case. I think it happens because we have an outer FloatRefTarget with inner pandoc.Figure nodes, per our filter trace:

  - t: "Para"
    content: "Hi."
  - customAST: true
    type: "Figure"
    identifier: "fig-1"
    t: "FloatRefTarget"
    attributes: []
    classes: []
    scaffold:
      - t: "Div"
        attr: "('', [], ['__quarto_custom_scaffold,true'])"
        content:
          - t: "Figure"
            attr: "('', [], [])"
            content:
              - t: "Plain"
                content:
                  - t: "Image"
                    attr: "('', [], [])"
                    caption: "An inner caption"
                    src: "data:image/png;base64,..."
                    title: ""
            caption:
              - null
              -
                - t: "Plain"
                  c:
                    - t: "Str"
                      c: "An"
                    - t: "Space"
                    - t: "Str"
                      c: "inner"
                    - t: "Space"
                    - t: "Str"
                      c: "caption"
          - t: "Figure"
            attr: "('', [], [])"
            content:
              - t: "Plain"
                content:
                  - t: "Image"
                    attr: "('', [], [])"
                    caption: "An inner caption"
                    src: "data:image/png;base64,..."
                    title: ""
            caption:
              - null
              -
                - t: "Plain"
                  c:
                    - t: "Str"
                      c: "An"
                    - t: "Space"
                    - t: "Str"
                      c: "inner"
                    - t: "Space"
                    - t: "Str"
                      c: "caption"
      - t: "Div"
        attr: "('', [], ['__quarto_custom_scaffold,true'])"
        content:
          - t: "Plain"
            content: "An outer caption."

[gordonwoodhull]

Very helpful context. The original example above produces

with LaTeX.

And this is what I'll enable here, probably by looking for this case with a walk in layout, rather than risk changing the has_subfloats logic in crossref_mark_subfloats() (although maybe worth trying both).