Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typst: Move Pandoc interpolated variable from typst-template.typ to typst-show.typ #10220

Closed

Conversation

christopherkenny
Copy link
Contributor

Description

One Pandoc variable was referenced in typst-template.typ. This moves it to the typst-show.typ file, adding a new variable to the article function call.

Closes #10212.

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog

@cderv cderv requested a review from gordonwoodhull July 4, 2024 09:33
@cscheid
Copy link
Collaborator

cscheid commented Jul 8, 2024

Since this means we honor abstract-title on typst now, we should change src/resources/schema/document-attributes.yml and rerun quarto build-js to get autocompletions to work.

@gordonwoodhull
Copy link
Contributor

I've tested and I think we should merge and backport, to maintain the convention of referencing Pandoc variables / metadata only in typst-show.typ

@gordonwoodhull
Copy link
Contributor

Ah, didn't see this at first, but now I see - yes my i18n changes in #9829 enabled abstract-title for Typst as a side-effect. We should reflect that in the schema. Will do!

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Jul 8, 2024

Merged to main, along with the schema change. Will backport now. Thanks @christopherkenny!

@cscheid
Copy link
Collaborator

cscheid commented Jul 8, 2024

@gordonwoodhull If you're at it, adding abstract-title to our feature-format matrix would be a good thing.

@gordonwoodhull
Copy link
Contributor

Sure... I don't think we have entered any related features. Judging from the docs, I think this should go under

feature-format-matrix/qmd-files/title-blocks/metadata-labels/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typst: 1.6 introduces Pandoc interpolated variable to typst-template.typ rather than typst-show.typ
3 participants