Use MapProperty instead of Map

[britter]

Changes the type of quarkusBuildProperties from Map to MapProperty. This
allows build authors to specify values which may only become available
later in the build by passed into the build using providers.

Follow up to #29971

[britter]

This is a breaking change in the extensions public API. If this has been released already I guess we have to deprecate and point to a new method instead.

[aloubyansky]

Yes, it has been released already, unfortunately.

[geoand]

@aloubyansky even if this is a breaking change, who would it affect?

[aloubyansky]

@jacobdotcosta would this change break your use-case?

[britter]

This change can break builds depending on how people use QuarkusPluginExtension:

// works
quarkus {
  set("prop", "some value")
}

quarkus {
  quarkusBuildProperties.put("prop", "some prop")
}

// assignment works, passing the reference may be broken
val props = quarkus.quarkusBuildProperties

// broken
val props: Map<String, String> = quarkus.quarkusBuildProperties

// broken
quarkus.quarkusBuildProperties.entrySet()

So if you want to go the safe route, it would be better to add a new accessor method instead, potentially deprecating the old one.

[aloubyansky]

Given that it's a very recent feature and this change encourages a good practice, I'd accept this change.

[aloubyansky]

FYI @glefloch

[aloubyansky]

@britter could you please squash the commits?

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.