Avoid adding the exception itself as a suppressed exception

[gsmet]

As experienced in #30463, it seems it can happen.

@geoand I think this will help with the weird error message the user had in #30463 .

[geoand]

Good idea!

[quarkus-bot]

Failing Jobs - Building cec7cd3

Status	Name	Step	Failures	Logs	Raw logs
✖	Devtools Tests - JDK 11	Build	Failures	Logs	Raw logs
✖	Devtools Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
✖	Devtools Tests - JDK 17	Build	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17
✔️	JVM Tests - JDK 18
✖	Native Tests - Data6	Download Maven Repo	⚠️ Check →	Logs	Raw logs
⌛	Native Tests - Misc4	Build	⚠️ Check →	Logs	Raw logs
✖	Quickstarts Compilation - JDK 17	Download Maven Repo	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Devtools Tests - JDK 11 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

✖ io.quarkus.devtools.codestarts.quarkus.HibernateOrmCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): HibernateOrmCodestartTest/testContent/src_main_kotlin_ilove_quark_us_MyKotlinEntity.kt] 
Path:

✖ io.quarkus.devtools.codestarts.quarkus.HibernateOrmPanacheKotlinCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): HibernateOrmPanacheKotlinCodestartTest/testContent/src_main_kotlin_ilove_quark_us_MyKotlinEntity.kt] 
Path:

---

⚙️ Devtools Tests - JDK 17 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

✖ io.quarkus.devtools.codestarts.quarkus.HibernateOrmCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): HibernateOrmCodestartTest/testContent/src_main_kotlin_ilove_quark_us_MyKotlinEntity.kt] 
Path:

✖ io.quarkus.devtools.codestarts.quarkus.HibernateOrmPanacheKotlinCodestartTest.testContent line 23 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): HibernateOrmPanacheKotlinCodestartTest/testContent/src_main_kotlin_ilove_quark_us_MyKotlinEntity.kt] 
Path:

---

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/elytron-security-jdbc/deployment 
! Skipped: integration-tests/elytron-security-jdbc 

📦 extensions/elytron-security-jdbc/deployment

✖ io.quarkus.elytron.security.jdbc.MinimalConfigurationTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.deployment.steps.ConfigGenerationBuildStep#checkForBuildTimeConfigChange threw an exception: java.lang.UnsupportedOperationException

✖ io.quarkus.elytron.security.jdbc.MultipleDataSourcesTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.deployment.steps.ConfigGenerationBuildStep#watchConfigFiles threw an exception: java.lang.UnsupportedOperationException

[gsmet]

@radcortez the failure in io.quarkus.elytron.security.jdbc.MinimalConfigurationTest and io.quarkus.elytron.security.jdbc.MultipleDataSourcesTest looks suspicious.

It fails with:

Caused by: java.lang.UnsupportedOperationException
	at io.quarkus.test.junit.RunningAppConfigResolver$1.getConfigValue(RunningAppConfigResolver.java:47)
	at io.quarkus.deployment.steps.ConfigGenerationBuildStep.checkForBuildTimeConfigChange(ConfigGenerationBuildStep.java:355)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:281)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
	at java.base/java.lang.Thread.run(Thread.java:829)
	at org.jboss.threads.JBossThread.run(JBossThread.java:501)

Apart from having a look at what's going on, I think we should add an error message to the exception.

[radcortez]

I'll have a look.

[radcortez]

I was not able to reproduce the failures locally.

I believe the previous test causes the failures error:

2023-01-19T19:37:03.5871617Z [INFO] Running io.quarkus.elytron.security.jdbc.CustomRoleDecoderTest
2023-01-19T19:37:03.7693303Z BasicLoggingEnabler failed to retrieve config: java.lang.NullPointerException
2023-01-19T19:37:03.7694394Z 2023-01-19 19:37:03,436 ERROR [io.qua.dep.dev.fil.wat.WatchServiceFileSystemWatcher] (Quarkus Test Watcher - 0) Failed to invoke watch callback [Error Occurred After Shutdown]: java.lang.RuntimeException: java.lang.InterruptedException: sleep interrupted
2023-01-19T19:37:03.7695744Z 	at io.quarkus.deployment.dev.RuntimeUpdatesProcessor$2.handleChanges(RuntimeUpdatesProcessor.java:237)
2023-01-19T19:37:03.7696906Z 	at io.quarkus.deployment.dev.filesystem.watch.WatchServiceFileSystemWatcher.invokeCallback(WatchServiceFileSystemWatcher.java:230)
2023-01-19T19:37:03.7697822Z 	at io.quarkus.deployment.dev.filesystem.watch.WatchServiceFileSystemWatcher.run(WatchServiceFileSystemWatcher.java:138)
2023-01-19T19:37:03.7698543Z 	at java.base/java.lang.Thread.run(Thread.java:829)
2023-01-19T19:37:03.7952231Z Caused by: java.lang.InterruptedException: sleep interrupted
2023-01-19T19:37:03.7952631Z 	at java.base/java.lang.Thread.sleep(Native Method)
2023-01-19T19:37:03.7953073Z 	at io.quarkus.deployment.dev.RuntimeUpdatesProcessor$2.handleChanges(RuntimeUpdatesProcessor.java:234)
2023-01-19T19:37:03.7953419Z 	... 3 more
2023-01-19T19:37:03.7953532Z 
2023-01-19T19:37:03.7954086Z 2023-01-19 19:37:03,502 INFO  [io.quarkus] (Test runner thread) quarkus-elytron-security-jdbc-deployment(test application) stopped in 0.113s
2023-01-19T19:37:06.8272110Z 2023-01-19 19:37:06,796 INFO  [io.qua.dev.h2.dep.H2DevServicesProcessor] (build-61) Dev Services for H2 started.
2023-01-19T19:37:06.8273084Z 2023-01-19 19:37:06,819 INFO  [io.qua.dat.dep.dev.DevServicesDatasourceProcessor] (build-61) Dev Services for the default datasource (h2) started
2023-01-19T19:37:07.8356067Z 2023-01-19 19:37:07,763 INFO  [io.quarkus] (main) quarkus-elytron-security-jdbc-deployment 999-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 3.525s. Listening on: http://localhost:8081
2023-01-19T19:37:07.8357013Z 2023-01-19 19:37:07,763 INFO  [io.quarkus] (main) Profile test activated. 
2023-01-19T19:37:07.8357900Z 2023-01-19 19:37:07,763 INFO  [io.quarkus] (main) Installed features: [agroal, cdi, jdbc-h2, narayana-jta, resteasy, security, security-jdbc, servlet, smallrye-context-propagation, vertx]
2023-01-19T19:37:09.1692154Z 2023-01-19 19:37:09,160 INFO  [io.quarkus] (main) quarkus-elytron-security-jdbc-deployment stopped in 0.050s
2023-01-19T19:37:09.1739480Z [INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.59 s - in io.quarkus.elytron.security.jdbc.CustomRoleDecoderTest
2023-01-19T19:37:09.1754940Z [INFO] Running io.quarkus.elytron.security.jdbc.MinimalConfigurationTest
2023-01-19T19:37:09.4910371Z 2023-01-19 19:37:09,418 INFO  [io.quarkus] (Test runner thread) quarkus-elytron-security-jdbc-deployment 999-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 1.399s. Listening on: http://localhost:8081
2023-01-19T19:37:09.4911326Z 2023-01-19 19:37:09,419 INFO  [io.quarkus] (Test runner thread) Profile test activated. 
2023-01-19T19:37:09.4912101Z 2023-01-19 19:37:09,419 INFO  [io.quarkus] (Test runner thread) Installed features: [agroal, cdi, jdbc-h2, narayana-jta, resteasy, security, security-jdbc, servlet, smallrye-context-propagation, vertx]
2023-01-19T19:37:09.9696402Z [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.777 s <<< FAILURE! - in io.quarkus.elytron.security.jdbc.MinimalConfigurationTest
2023-01-19T19:37:09.9697343Z [ERROR] io.quarkus.elytron.security.jdbc.MinimalConfigurationTest  Time elapsed: 0.777 s  <<< ERROR!
2023-01-19T19:37:09.9697827Z java.lang.RuntimeException: 
2023-01-19T19:37:09.9698298Z java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
2023-01-19T19:37:09.9699005Z 	[error]: Build step io.quarkus.deployment.steps.ConfigGenerationBuildStep#checkForBuildTimeConfigChange threw an exception: java.lang.UnsupportedOperationException

So, the RunningAppConfigResolver is not cleared from ConfigProviderResolver. We could probably implement the unsupported methods, but this will hide the error further because we are not in the correct classloader or config. I'll change the error to be more explanatory.

[gsmet]

@radcortez but don't we have a bug if the tests are not properly isolated?

[radcortez]

I believe the issues are not on the test themselves but probably here:

quarkus/core/deployment/src/main/java/io/quarkus/deployment/dev/RuntimeUpdatesProcessor.java

Lines 232 to 238 in 868a4c9

	try {
	if (context.isTest()) {
	Thread.sleep(500);
	}
	} catch (InterruptedException e) {
	throw new RuntimeException(e);
	}

Probably this is not calling close in the test extension. Regardless, you still get a test failure from the test that caused the exception. It may be tricky to figure out what is causing the InterruptedException.

Does this make sense?