Fix HibernateOrmCodestart

[ia3andy]

This test in generating code for Java, I removed the line testing a kotlin file (there is a specific test for kotlin).

[quarkus-bot]

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

[yrodiere]

@ia3andy There isn't any test for Kotlin as far as I can see? The only one I can see is HibernateOrmPanacheKotlinCodestartTest.java and that's for Hibernate ORM with Panache, not for Hibernate ORM alone.

[ia3andy]

@ia3andy There isn't any test for Kotlin as far as I can see? The only one I can see is HibernateOrmPanacheKotlinCodestartTest.java and that's for Hibernate ORM with Panache, not for Hibernate ORM alone.

good catch!

[ia3andy]

Ok things where in a inconsistant state, I guess the test was passing at some point but the codestart was changed and the snapshot was not updated accordingly.

Also there was a file in the kotlin codestart which should not have been there.

I've also renamed to IT instead of test as they are build/running the app and not just testing the content

As you said @yrodiere there was no hibernate kotlin test so I added one.

[ia3andy]

if things keep failing after this patch, @gsmet let me know and I'll dig deeper.

[loicmathieu]

LGTM

[quarkus-bot]

Failing Jobs - Building 277b190

Status	Name	Step	Failures	Logs	Raw logs
✖	MicroProfile TCKs Tests	Verify	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/resteasy-reactive 

📦 tcks/resteasy-reactive

✖ Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.0.0:exec (test) on project quarkus-tck-resteasy-reactive: Command execution failed.

📦 tcks/resteasy-reactive/target/testsuite/tests

✖ com.sun.ts.tests.jaxrs.ee.resource.java2entity.JAXRSClient0154. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#registerBeans threw an exception: javax.enterprise.inject.spi.DefinitionException: Cannot limit bean types to types outside of the transitive closure of bean types. Bean: com.sun.ts.tests.jaxrs.ee.resource.java2entity.CollectionWriter illegal bean types: [javax.ws.rs.ext.MessageBodyWriter]

✖ com.sun.ts.tests.jaxrs.ee.rs.core.configurable.JAXRSClient0133. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#registerBeans threw an exception: javax.enterprise.inject.spi.DefinitionException: Cannot limit bean types to types outside of the transitive closure of bean types. Bean: com.sun.ts.tests.jaxrs.api.rs.core.configurable.CallableProvider illegal bean types: [javax.ws.rs.ext.MessageBodyWriter, javax.ws.rs.ext.MessageBodyReader]

✖ com.sun.ts.tests.jaxrs.ee.rs.core.configuration.JAXRSClient0125. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#registerBeans threw an exception: javax.enterprise.inject.spi.DefinitionException: Cannot limit bean types to types outside of the transitive closure of bean types. Bean: com.sun.ts.tests.jaxrs.api.rs.core.configurable.CallableProvider illegal bean types: [javax.ws.rs.ext.MessageBodyWriter, javax.ws.rs.ext.MessageBodyReader]

✖ com.sun.ts.tests.jaxrs.spec.resource.responsemediatype.JAXRSClient0016. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.arc.deployment.ArcProcessor#registerBeans threw an exception: javax.enterprise.inject.spi.DefinitionException: Cannot limit bean types to types outside of the transitive closure of bean types. Bean: com.sun.ts.tests.jaxrs.spec.resource.responsemediatype.MediaWriter illegal bean types: [javax.ws.rs.ext.MessageBodyWriter]

[gsmet]

@manovotn could the failures be related to your recent changes to ArC?

[gsmet]

OK, let's get this in!

[manovotn]

@gsmet yes the the MP TCK are definitely related.
It's this PR - #30452 but the CI there passed without these failures?

EDIT: Meaning of the failure is that someone is trying to limit bean types via @Typed to types that don't belong to the bean. Such as having a [String, Object] typed bean and trying to claim it's [Integer] instead.
IIRC, such illegal types were just ignored before whereas we now throw an exception.

[manovotn]

@gsmet I don't know that much about RR, but I am aware of some such magic being done here - https://github.com/quarkusio/quarkus/blob/main/extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment/src/main/java/io/quarkus/resteasy/reactive/server/deployment/ResteasyReactiveProcessor.java#L750-L751
But that doesn't look like it since that should only limit the bean type to the impl class; the exception complains about types such as javax.ws.rs.ext.MessageBodyWriter...

[manovotn]

I think I found it, it's actually in ResteasyReactiveProcessor, namely here we are adding interface types as well with no validation.
This is now causing issue because some of those interface types can have wildcards in them which removed them from bean types but we'll still attempt to restrict the bean type to it.

We'd need to filter out any interface types that have wildcards in them. Though I have no idea how this affects RR functionality.

[gsmet]

Probably something to discuss with @geoand next week.

[geoand]

We'd need to filter out any interface types that have wildcards in them. Though I have no idea how this affects RR functionality.

I think we can probably safely do this

[manovotn]

I took a closer look and wasted some time trying to implement what I said above while in fact limiting the types by wildcards would be pretty complex and not really needed.
Instead, Arc should compare types declared via @Typed with unrestricted bean type set (including all types, even those we eventually remove). I'll submit a PR and mark you for review.