Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Knative Quickstart #112

Open
kameshsampath opened this issue Mar 22, 2019 · 9 comments
Open

Improve Knative Quickstart #112

kameshsampath opened this issue Mar 22, 2019 · 9 comments
Assignees
@kameshsampath

Comments

@kameshsampath
Copy link
Contributor

Improve Knative Quickstart to:

  1. Upgrade to v0.12.0
  2. Improve on docker build
  3. Use official docker builder images

@cescoffier - can you please assign this task to me ?
@cescoffier
Copy link
Member

Thanks @kameshsampath to move this forward!

@kameshsampath
Copy link
Contributor Author

@cescoffier - do I need to send the PR to development branch or to master ?

@kameshsampath kameshsampath mentioned this issue Mar 25, 2019
Closed
@cescoffier
Copy link
Member

master is ok as it should work on Quarkus 0.12.0 (can you confirm this BTW?)

@kameshsampath kameshsampath mentioned this issue Mar 25, 2019
Closed
kameshsampath added a commit to kameshsampath/quarkusio.github.io that referenced this issue Mar 26, 2019
@kameshsampath
(fix): simplify knative quickstart
e23fa26 
Simplfy the Knative quick start, use the official container images

Related quarkusio/quarkus-quickstarts#112

Fixes: quarkusio#149
@kameshsampath kameshsampath mentioned this issue Mar 26, 2019
Closed
@kameshsampath
Copy link
Contributor Author

kameshsampath commented Mar 26, 2019 •
edited
Loading

master is ok as it should work on Quarkus 0.12.0 (can you confirm this BTW?)

I see that is working with v0.12.0

FYI @cescoffier

@kameshsampath kameshsampath mentioned this issue Mar 26, 2019
Closed
kameshsampath added a commit to kameshsampath/quarkus that referenced this issue Mar 26, 2019
@kameshsampath
(docs): Update Knative Quickstart guide
bae132a 
 Update dKnative Quickstart guide for  quarkusio/quarkus-quickstarts#112

Fixes:  quarkusio#1698
@kameshsampath kameshsampath mentioned this issue Mar 26, 2019
Closed
@kameshsampath
Copy link
Contributor Author

@cescoffier - any idea when this will get merged?

@fhopfensperger
Copy link

I think the quickstart needs to be totally rewritten, as knative deprecated knative builds.
See knative/build#614

@kameshsampath
Copy link
Contributor Author

kameshsampath commented Jan 29, 2020 via email

@kameshsampath
Copy link
Contributor Author

@cescoffier and @fhopfensperger - am rewriting this now and send a PR

@kameshsampath kameshsampath mentioned this issue Feb 9, 2020
Merged
@kameshsampath
Copy link
Contributor Author

@cescoffier , @fhopfensperger - the updates are here #462 for review and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kameshsampath kameshsampath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(fix): simplify and improve knative quickstart
3 participants
@cescoffier @kameshsampath @fhopfensperger