Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs): Update Knative Quickstart guide #1699

Closed
wants to merge 2 commits into from

Conversation

kameshsampath
Copy link
Contributor

Update dKnative Quickstart guide for quarkusio/quarkus-quickstarts#112

Fixes: #1698

@kameshsampath
Copy link
Contributor Author

FYI: @gsmet @cescoffier - sorry for opening the issue in other site repo. moved it here and closed the other one.

Copy link
Contributor

@starksm64 starksm64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running through the guide. I went to https://kubernetes.io/docs/tasks/tools/install-minikube/ and followed the steps to install minikube and dependcies on an osx box using brew. On the first command minikube crashed:

Scotts-iMacPro:docs starksm$ eval $(minikube docker-env)

💣  Error getting host: Machine does not exist for api.Exists(minikube)

😿  Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉  https://github.com/kubernetes/minikube/issues/new

Scotts-iMacPro:docs starksm$ minikube version
minikube version: v1.0.0

@starksm64
Copy link
Contributor

I guess I needed to have started minikube before the eval $(minikube docker-env) command.

@kameshsampath
Copy link
Contributor Author

oh yeah ! you are right

@starksm64
Copy link
Contributor

It says to run a maven command, but I don't see one in the merged getting-started-knative. If I do the step after docker-env eval, I don't have a Dockerfile so it is failing:

Scotts-iMacPro:docs starksm$ docker build -t starksm64/getting-started-knative . 
unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /Users/starksm/Dev/JBoss/Protean/starksm64-quarkus/docs/Dockerfile: no such file or directory

so either I'm supposed to using the solution or there is a maven command to setup a new project that is missing.

@kameshsampath
Copy link
Contributor Author

@starksm64 - for all the commands in this to work well, you might need the PR quarkusio/quarkus-quickstarts#117 merged as that uses the latest quarkus maven images

@starksm64
Copy link
Contributor

Ok, but the getting-started-knative-guide.html seems to be missing something. Here is what I see in it:
mvn-cmd

there is a reference to a maven command, but I don't see one.

@kameshsampath
Copy link
Contributor Author

@starksm64 you dont need the maven command explicitly, the build takes care of it. Also you cant build from macbook directly for the old get started. the new PR which I mentioned ( needs to be merged) can allow you to do the build directly from mac

@starksm64
Copy link
Contributor

Ok, I did try the new quickstart PR branch and left a comment on that about not being able to get past the first docker build -t {username}/getting-started-knative . step as the image build failed with a 137 status code.

@rsvoboda
Copy link
Member

rsvoboda commented Apr 1, 2019

Hi. This PR and knative guide are mentioning docker.io. Q is focused on quay.io.
Please update the PR and examples to use quay.io registry.

git grep docker.io
docs/src/main/asciidoc/getting-started-knative-guide.adoc:| https://index.docker.io/v1/
docs/src/main/asciidoc/getting-started-knative-guide.adoc:| docker.io/demo/quarkus-knative-quickstart
docs/src/main/asciidoc/getting-started-knative-guide.adoc:    -Dapp.container.image='docker.io/demo/getting-started-knative' \
extensions/kubernetes/deployment/src/main/java/io/quarkus/kubernetes/deployment/DockerConfig.java:    public String registry = "docker.io";

@kameshsampath
Copy link
Contributor Author

@rsvoboda - i would also be happy to use quay.io but then for the knative i have to use docker or gcr repos which are v2_2 enabled. Quay is not set default v2_2 for all the registered users. Once I see the quay release happening we can move to use quay.io

@n1hility n1hility requested a review from starksm64 April 30, 2019 23:03
@dmlloyd
Copy link
Member

dmlloyd commented May 7, 2019

Any updates on this? @starksm64 ?

@starksm64
Copy link
Contributor

I'll go through it again today to see the current status. Last time I tried it was failing with remote repository issues.

@cescoffier
Copy link
Member

Any update on this? @kameshsampath @starksm64

@kameshsampath
Copy link
Contributor Author

@cescoffier am waiting on @starksm64 for any update on the issues he was facing. But this gives me a chance to update it for 0.16.0 and push again. WDYT?

@cescoffier
Copy link
Member

@kameshsampath yes, please update.

@kameshsampath
Copy link
Contributor Author

@cescoffier an effective close to this will be merging the PRS:

I have updated and rebased all the PRs for 0.16.0 and graal rc16

@emmanuelbernard
Copy link
Member

@cescoffier @kameshsampath so 0.18 is about to land with GraalVM 19.0.2 support. Maybe a good time to refresh that PR in that occasion right after the release.

@dmlloyd
Copy link
Member

dmlloyd commented Jul 10, 2019

Now that 0.18 (and 0.19) have been released, do we want to update this further?

/cc @cescoffier @kameshsampath

@cescoffier
Copy link
Member

@kameshsampath can you have a look?

@kameshsampath
Copy link
Contributor Author

@cescoffier - I will mid of next week

@kameshsampath
Copy link
Contributor Author

@cescoffier - I have updated the doc, dont know why there is conflict I tried to rebase to the latest quickstarts.

I have also updated quarkusio/quarkus-quickstarts#117 the sources. Please merge them together.

Let me know if some action is required.

@cescoffier
Copy link
Member

Closing due to inactivity.

@cescoffier cescoffier closed this Nov 12, 2019
@cescoffier cescoffier added the triage/invalid This doesn't seem right label Nov 12, 2019
@kameshsampath
Copy link
Contributor Author

rather than inactivity there was no response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Knative Quickstart guide
6 participants