-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(docs): Update Knative Quickstart guide #1699
Conversation
Update dKnative Quickstart guide for quarkusio/quarkus-quickstarts#112 Fixes: quarkusio#1698
FYI: @gsmet @cescoffier - sorry for opening the issue in other site repo. moved it here and closed the other one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running through the guide. I went to https://kubernetes.io/docs/tasks/tools/install-minikube/ and followed the steps to install minikube and dependcies on an osx box using brew. On the first command minikube crashed:
Scotts-iMacPro:docs starksm$ eval $(minikube docker-env)
💣 Error getting host: Machine does not exist for api.Exists(minikube)
😿 Sorry that minikube crashed. If this was unexpected, we would love to hear from you:
👉 https://github.com/kubernetes/minikube/issues/new
Scotts-iMacPro:docs starksm$ minikube version
minikube version: v1.0.0
I guess I needed to have started minikube before the |
oh yeah ! you are right |
It says to run a maven command, but I don't see one in the merged getting-started-knative. If I do the step after docker-env eval, I don't have a Dockerfile so it is failing: Scotts-iMacPro:docs starksm$ docker build -t starksm64/getting-started-knative .
unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /Users/starksm/Dev/JBoss/Protean/starksm64-quarkus/docs/Dockerfile: no such file or directory so either I'm supposed to using the solution or there is a maven command to setup a new project that is missing. |
@starksm64 - for all the commands in this to work well, you might need the PR quarkusio/quarkus-quickstarts#117 merged as that uses the latest quarkus maven images |
@starksm64 you dont need the maven command explicitly, the build takes care of it. Also you cant build from macbook directly for the old get started. the new PR which I mentioned ( needs to be merged) can allow you to do the build directly from mac |
Ok, I did try the new quickstart PR branch and left a comment on that about not being able to get past the first |
Hi. This PR and knative guide are mentioning docker.io. Q is focused on quay.io.
|
@rsvoboda - i would also be happy to use quay.io but then for the knative i have to use docker or gcr repos which are |
Any updates on this? @starksm64 ? |
I'll go through it again today to see the current status. Last time I tried it was failing with remote repository issues. |
Any update on this? @kameshsampath @starksm64 |
@cescoffier am waiting on @starksm64 for any update on the issues he was facing. But this gives me a chance to update it for |
@kameshsampath yes, please update. |
@cescoffier an effective close to this will be merging the PRS:
I have updated and rebased all the PRs for 0.16.0 and graal rc16 |
@cescoffier @kameshsampath so 0.18 is about to land with GraalVM 19.0.2 support. Maybe a good time to refresh that PR in that occasion right after the release. |
Now that 0.18 (and 0.19) have been released, do we want to update this further? |
@kameshsampath can you have a look? |
@cescoffier - I will mid of next week |
9efd168
to
5fb1e05
Compare
@cescoffier - I have updated the doc, dont know why there is conflict I tried to rebase to the latest quickstarts. I have also updated quarkusio/quarkus-quickstarts#117 the sources. Please merge them together. Let me know if some action is required. |
Closing due to inactivity. |
rather than inactivity there was no response |
Update dKnative Quickstart guide for quarkusio/quarkus-quickstarts#112
Fixes: #1698