guide updates for knative quick start update #7100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
gsmet
requested changes
Feb 12, 2020
| or https://knative.dev/v0.6-docs/install/knative-with-minishift/[Minishift] | ||
|
|
||
|
|
||
| * having access to a Kubernetes cluster. Minikube are valid options. |
There was a problem hiding this comment.
Suggested change
| * having access to a Kubernetes cluster. Minikube are valid options. | |
| * having access to a Kubernetes cluster. Minikube is a valid option. |
| This guide covers: | ||
|
|
||
| * The deployment of the application to Kubernetes | ||
| * The deployment of the application to Knative |
There was a problem hiding this comment.
Maybe let's remove the bullet list if you have only one item (and add a dot at the end of the sentence)?
| @@ -39,106 +36,95 @@ Clone the Git repository: `git clone {quickstarts-clone-url}`, or download an {q | |||
|
|
|||
| The solution is located in the `getting-started-knative` directory. | |||
|
|
|||
| == Deploying the application in Knative | |||
| == Setup Kubernetes Cluster | |||
There was a problem hiding this comment.
Suggested change
| == Setup Kubernetes Cluster | |
| == Set up Kubernetes Cluster |
| ==== | ||
| If you are not using private GitHub repo then you dont need the `Deploy Key` created and added to the Build Service Account | ||
| ==== | ||
| <1> Make the current docker context to be that of minikube |
There was a problem hiding this comment.
Suggested change
| <1> Make the current docker context to be that of minikube | |
| <1> Make the current Docker context to be that of minikube |
| using Dockerfile and https://github.com/GoogleContainerTools/kaniko[Kaniko]. After a successful build you will have the | ||
| Knative serving application deployed with the built container image. You can watch the application build pods using the | ||
| command `kubectl get pods -w`. You can terminate the watch using the command kbd:[CTRL + c] | ||
| == Setup Nexus(Optional) |
There was a problem hiding this comment.
Suggested change
| == Setup Nexus(Optional) | |
| == Set up Nexus (Optional) |
| and copy them to `${project.build.directory}/knative` | ||
|
|
||
| Run the following command to create the Knative resources: | ||
| It is very important to note that the Dockerfile in src/main/docker folder has been modified to support |
| ---- | ||
|
|
||
| == Accessing your application | ||
| As it will take few minutes for the build and deploy to be completed you can watch the status using: |
There was a problem hiding this comment.
Suggested change
| As it will take few minutes for the build and deploy to be completed you can watch the status using: | |
| As it will take a few minutes for the build and deployment to complete, you can watch the status using: |
| greeter-deployment-5749cc98fc-gs6zr 2/2 Running 10s | ||
| ---- | ||
|
|
||
| NOTE: The deployment name could differ in your environment |
There was a problem hiding this comment.
Suggested change
| NOTE: The deployment name could differ in your environment | |
| NOTE: The deployment name could differ in your environment. |
|
|
||
| The application is now exposed as an internal service. If you are using `minikube` or `minishift`, you can access it using: | ||
| A successful Knative Service deployment will show the following pods in the current namespace: |
There was a problem hiding this comment.
Suggested change
| A successful Knative Service deployment will show the following pods in the current namespace: | |
| A successful Knative service deployment will show the following pods in the current namespace: |
|
|
||
| NOTE: The deployment name could differ in your environment | ||
|
|
||
| Once the Knative service is successfully running, you can call the service it using the script `./bin/call.sh`, which should return a response like `hello`. Allowing it to idle for approximately 60-65 seconds -- that is without any further requests --, you will see it automatically scales down to zero pods. |
There was a problem hiding this comment.
Suggested change
| Once the Knative service is successfully running, you can call the service it using the script `./bin/call.sh`, which should return a response like `hello`. Allowing it to idle for approximately 60-65 seconds -- that is without any further requests --, you will see it automatically scales down to zero pods. | |
| Once the Knative service is successfully running, you can call the service using the script `./bin/call.sh`, which should return a response like `hello`. Allowing it to idle for approximately 60-65 seconds - that is without any further requests -, you will see it automatically scales down to zero pods. |
kameshsampath
force-pushed
the
issue-112-docs
branch
from
b618497 to
df8f7a3
Compare
|
@gsmet thank you for quick review, I have updated your comments and pushed it back . It will be great of you can check and merge the related code quarkusio/quarkus-quickstarts#112 |
|
@kameshsampath I think you missed the hidden ones (there are 9 of them hidden by GH). At least they are not marked as outdated. |
kameshsampath
force-pushed
the
issue-112-docs
branch
from
df8f7a3 to
c8ee8a3
Compare
Not sure how I missed them , sorry about. They are all addressed in the latest commit. |
gsmet
force-pushed
the
issue-112-docs
branch
from
c8ee8a3 to
4df1873
Compare
gsmet
approved these changes
Feb 21, 2020
|
Squashed and merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guide has been updated for the quarkusio/quarkus-quickstarts#112