Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[llava][5/N] Add Llava model definition #4259

Closed
wants to merge 20 commits into from
Closed

[llava][5/N] Add Llava model definition #4259

wants to merge 20 commits into from

Conversation

larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Jul 12, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D59759978

@larryliu0820
[llava][5/N] Add Llava model definition
65fad28 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced Jul 12, 2024
Closed
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4259

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b8e9c82 with merge base ef640bf (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 12, 2024
Closed
Closed
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 12, 2024
larryliu0820 added a commit that referenced this pull request Jul 12, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
d3b431e 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 5c7765c7ccbeafb1e2e6344ead571f948d8deb69
Pull Request resolved: #4259
@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
dd57963 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 15, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
d3ac30b 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: beadc8459fc3ccadbf87276d8fc34ac9878622a1
Pull Request resolved: #4259
@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
f7a0482 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 15, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
173b0a7 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 1eb1b84cd332d130d62e4a0a8ea363c3ca727fd2
Pull Request resolved: #4259
@larryliu0820 larryliu0820 marked this pull request as draft July 15, 2024 16:32
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
a8bd09b 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 16, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
d381e5d 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 72ee3154643b3f296c48f4e03e84d85749d82f26
Pull Request resolved: #4259
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
6371fd5 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 16, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
ab9a73b 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 46e5a580db628674bb6cdeda96ad5982d3101c86
Pull Request resolved: #4259
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
97899eb 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 16, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
bac14bc 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 46e5a580db628674bb6cdeda96ad5982d3101c86
Pull Request resolved: #4259
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
7478ce8 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 16, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
b526773 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 7fd524b37447e8fbc27b4bd996de77de7f230bbf
Pull Request resolved: #4259
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
aae49f2 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 17, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
678bd21 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 295ba529974f6f67fcf029fcdcd909812123e3ab
Pull Request resolved: #4259
@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
ff14fec 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 17, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
a4775b2 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 295ba529974f6f67fcf029fcdcd909812123e3ab
Pull Request resolved: #4259
@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
ec370c9 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 17, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
920ee52 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ff0f8f6657b0b6dae3115f43f2d2bfb760f2b20c
Pull Request resolved: #4259
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
fda4e28 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 18, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
b4456ae 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 4f7157d368a770c307278c1505030ba3c655f701
Pull Request resolved: #4259
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
b0cf0c8 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 18, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
f24bb8d 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: dc261a0c4061d04e0b4d3e7c9e4660e44e30cb16
Pull Request resolved: #4259
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
9e856c5 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 18, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
d79b445 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ba3c088963fe417edc1d574d9ddd6df895bf9c8f
Pull Request resolved: #4259
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
9a0eb13 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
larryliu0820 added a commit that referenced this pull request Jul 18, 2024
@larryliu0820
[llava][5/N] Add Llava model definition
5da66b3 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: c6abb1105a3cc45c505e205d159b4b4c253a802c
Pull Request resolved: #4259
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
a733abc 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
@larryliu0820 larryliu0820 mentioned this pull request Jul 18, 2024
Closed
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
054df9a 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
helunwencser
helunwencser approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@helunwencser helunwencser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Had some minor comments.

examples/models/llava/install_requirements.sh Show resolved Hide resolved
examples/models/llava/install_requirements.sh Show resolved Hide resolved
examples/models/llava/model.py Outdated Show resolved Hide resolved
examples/models/llava/main.py Outdated Show resolved Hide resolved
examples/models/llava/main.py Outdated Show resolved Hide resolved
examples/models/llava/model.py Outdated Show resolved Hide resolved
@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
ab66148 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Update on "[llava][5/N] Add Llava model definition"
b8e9c82 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D59759978](https://our.internmc.facebook.com/intern/diff/D59759978)

[ghstack-poisoned]
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

2 similar comments
@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@larryliu0820
Copy link
Contributor Author

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1933dae.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helunwencser helunwencser helunwencser approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larryliu0820 @facebook-github-bot @helunwencser