[llava][4/N] Allow llama_transformer take embedding as optional argument #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Llava run token embedding separately and combine that with image embeddings as input to text transformer. This PR adds support for that. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 12, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4257
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1e9ad23 with merge base fbe0af1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
added a commit
that referenced
this pull request
Jul 12, 2024
Summary: Llava run token embedding separately and combine that with image embeddings as input to text transformer. This PR adds support for that. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 398c39d3b398d417e215095982c8e0dfd5fa8090 Pull Request resolved: #4257
…ional argument" Summary: Llava run token embedding separately and combine that with image embeddings as input to text transformer. This PR adds support for that. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Jul 12, 2024
Summary: Llava run token embedding separately and combine that with image embeddings as input to text transformer. This PR adds support for that. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9cf46d027d5502ec03f65c597c2769b9cb2e6506 Pull Request resolved: #4257
…ional argument" Summary: Llava run token embedding separately and combine that with image embeddings as input to text transformer. This PR adds support for that. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tarun292
approved these changes
Jul 15, 2024
…ional argument" Summary: Llava run token embedding separately and combine that with image embeddings as input to text transformer. This PR adds support for that. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D59759977](https://our.internmc.facebook.com/intern/diff/D59759977) [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…ional argument" Summary: Llava run token embedding separately and combine that with image embeddings as input to text transformer. This PR adds support for that. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D59759977](https://our.internmc.facebook.com/intern/diff/D59759977) [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…ional argument" Summary: Llava run token embedding separately and combine that with image embeddings as input to text transformer. This PR adds support for that. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D59759977](https://our.internmc.facebook.com/intern/diff/D59759977) [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…ional argument" Summary: Llava run token embedding separately and combine that with image embeddings as input to text transformer. This PR adds support for that. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D59759977](https://our.internmc.facebook.com/intern/diff/D59759977) [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 8a1589d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Llava run token embedding separately and combine that with
image embeddings as input to text transformer. This PR adds support for
that.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D59759977