[llava][2/N] Rename llava_encoder to llava #4242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We are planning to support the full llava model so renaming the directory name. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4242
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 695c013 with merge base fbe0af1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
larryliu0820
added a commit
that referenced
this pull request
Jul 12, 2024
Summary: We are planning to support the full llava model so renaming the directory name. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f85549aa2464ef879dcc590957ef5bdb42f3f29b Pull Request resolved: #4242
Summary: We are planning to support the full llava model so renaming the directory name. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Jul 12, 2024
Summary: We are planning to support the full llava model so renaming the directory name. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4aa52becf3b09393584726c775db21332d94fb8f Pull Request resolved: #4242
Summary: We are planning to support the full llava model so renaming the directory name. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
larryliu0820
added a commit
that referenced
this pull request
Jul 12, 2024
Summary: We are planning to support the full llava model so renaming the directory name. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 737372b2a833b166da1cd30b970a0aad0b1132b9 Pull Request resolved: #4242
This was referenced Jul 12, 2024
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tarun292
approved these changes
Jul 15, 2024
Summary: We are planning to support the full llava model so renaming the directory name. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D59759979](https://our.internmc.facebook.com/intern/diff/D59759979) [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: We are planning to support the full llava model so renaming the directory name. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D59759979](https://our.internmc.facebook.com/intern/diff/D59759979) [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: We are planning to support the full llava model so renaming the directory name. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D59759979](https://our.internmc.facebook.com/intern/diff/D59759979) [ghstack-poisoned]
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 58b1b18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: We are planning to support the full llava model so renaming the
directory name.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D59759979