[ET-VK] Remove Functions.h/cpp #2245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In D53982443, OperatorRegistry.h/cpp and Functions.h/cpp were both introduced, as they were split across the PT and ET repos, but now both are in ET. ## OperatorRegistry.cpp Here, we see all our operators. OPERATOR_ENTRY maps from Vulkan Dialect op name to the OpFunction, which have an op-specific name. Note that all OpFunction carry the same function signature. ## Functions.h/cpp -> Arithmetic.h/cpp We don't need another place to see all our operators. They will each reference one ops/impl file, so we group them accordingly in their ops/impl file. ## Nit Also, sort `add_arithmetic_node()` declarations according to their execution order. Differential Revision: [D54370467](https://our.internmc.facebook.com/intern/diff/D54370467/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2245
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit bc969fc with merge base 566209d ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54370467 |
This was referenced Mar 4, 2024
SS-JIA
approved these changes
Mar 4, 2024
This was referenced Mar 5, 2024
|
This pull request has been merged in dfb5f51. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
In D53982443, OperatorRegistry.h/cpp and Functions.h/cpp were both introduced, as they were split across the PT and ET repos, but now both are in ET.
OperatorRegistry.cpp
Here, we see all our operators. OPERATOR_ENTRY maps from Vulkan Dialect op name to the OpFunction, which have an op-specific name. Note that all OpFunction carry the same function signature.
Functions.h/cpp -> Arithmetic.h/cpp
We don't need another place to see all our operators. They will each reference one ops/impl file, so we group them accordingly in their ops/impl file.
Nit
Also, sort
add_arithmetic_node()declarations according to their execution order.Differential Revision: D54370467