Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ET-VK] Remove Functions.h/cpp #2245

Closed
wants to merge 1 commit into from
Closed

[ET-VK] Remove Functions.h/cpp #2245

wants to merge 1 commit into from

Commits on Mar 4, 2024

  1. [ET-VK] Remove Functions.h/cpp 

    In D53982443, OperatorRegistry.h/cpp and Functions.h/cpp were both introduced, as they were split across the PT and ET repos, but now both are in ET.

## OperatorRegistry.cpp
Here, we see all our operators. OPERATOR_ENTRY maps from Vulkan Dialect op name to the OpFunction, which have an op-specific name. Note that all OpFunction carry the same function signature.

## Functions.h/cpp -> Arithmetic.h/cpp
We don't need another place to see all our operators. They will each reference one ops/impl file, so we group them accordingly in their ops/impl file.

## Nit
Also, sort `add_arithmetic_node()` declarations according to their execution order.

Differential Revision: [D54370467](https://our.internmc.facebook.com/intern/diff/D54370467/)

[ghstack-poisoned]
    @jorgep31415
    jorgep31415 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    bc969fc View commit details
    Browse the repository at this point in the history