[ET-VK][Op Redesign][7/n] Generalize ExecuteNode args with ArgGroup #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leftover from Op Redesign 5/n - D54445787. --- Typically, we specify outputs first and inputs second in the shader layout, but not always. In `image_to_nchw.glsl`, this is flipped: https://www.internalfb.com/code/fbsource/[d303d229f22616bfba32e5bb5d4d27dc656f41a7]/fbcode/caffe2/aten/src/ATen/native/vulkan/glsl/image_to_nchw.glsl?lines=8-19 Hence, we generalize our `ExecuteNode` specification to take a vector of args (image, buffer, etc.), with specification of access type. Since typically we will group args of the same access together, we correspond one access specification to multiple args. We reuse `api::MemoryAccessType` for access specification. Differential Revision: [D54518840](https://our.internmc.facebook.com/intern/diff/D54518840/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2262
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 413c954 with merge base 566209d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Mar 4, 2024
|
This pull request was exported from Phabricator. Differential Revision: D54518840 |
This was referenced Mar 5, 2024
jorgep31415
added a commit
that referenced
this pull request
Mar 5, 2024
Leftover from Op Redesign 5/n - D54445787. --- Typically, we specify outputs first and inputs second in the shader layout, but not always. In `image_to_nchw.glsl`, this is flipped: https://www.internalfb.com/code/fbsource/[d303d229f22616bfba32e5bb5d4d27dc656f41a7]/fbcode/caffe2/aten/src/ATen/native/vulkan/glsl/image_to_nchw.glsl?lines=8-19 Hence, we generalize our `ExecuteNode` specification to take a vector of args (image, buffer, etc.), with specification of access type. Since typically we will group args of the same access together, we correspond one access specification to multiple args. We reuse `api::MemoryAccessType` for access specification. Differential Revision: [D54518840](https://our.internmc.facebook.com/intern/diff/D54518840/) ghstack-source-id: 217489419 Pull Request resolved: #2262
SS-JIA
approved these changes
Mar 5, 2024
|
This pull request has been merged in 49fb74b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Leftover from Op Redesign 5/n - D54445787.
Typically, we specify outputs first and inputs second in the shader layout, but not always. In
image_to_nchw.glsl, this is flipped:https://www.internalfb.com/code/fbsource/[d303d229f22616bfba32e5bb5d4d27dc656f41a7]/fbcode/caffe2/aten/src/ATen/native/vulkan/glsl/image_to_nchw.glsl?lines=8-19
Hence, we generalize our
ExecuteNodespecification to take a vector of args (image, buffer, etc.), with specification of access type. Since typically we will group args of the same access together, we correspond one access specification to multiple args.We reuse
api::MemoryAccessTypefor access specification.Differential Revision: D54518840