Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41100: allow python to build for macosx-11.0-arm64 #21224

Closed

Conversation

lawrence-danna-apple
Copy link
Contributor

@lawrence-danna-apple lawrence-danna-apple commented Jun 29, 2020

allow python to build for macosx-11.0-arm64, by adding the appropriate case to configure.ac

https://bugs.python.org/issue41164

@ned-deily ned-deily changed the title bpo-41164: allow python to build for macosx-11.0-arm64 bpo-41100: allow python to build for macosx-11.0-arm64 Jun 30, 2020
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SMillerDev pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 4, 2020
This set of patches includes the following upstream pull requests:

- python/cpython#21114
  "Support `arm64` in Mac/Tools/pythonw"

- python/cpython#21224
  "allow python to build for macosx-11.0-arm64"

- python/cpython#21249
  "ctypes fixes for arm64 Mac OS"

Adding the patches before upstream has released them is warranted here
because `python@3.8` is widely used as a dependency, and the patch is
needed to enable testing dependent formulae on arm64.

CC: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com>
claui added a commit to Homebrew/formula-patches that referenced this pull request Jul 15, 2020
This set of patches includes the following upstream pull requests,
in this order:

- PR 20171, "Fix _tkinter use"
  python/cpython#20171
  (prerequisite for patch #21249 to apply)

- PR 21114, "Support `arm64` in Mac/Tools/pythonw"
  python/cpython#21114

- PR 21224, "allow python to build for macosx-11.0-arm64"
  python/cpython#21224

- PR 21249, "ctypes fixes for arm64 Mac OS"
  python/cpython#21249

The patches for 20171 and 21249 have been minimally modified in order
to backport them to 3.8.3.

Note that these have been successfully tested for `python@3.8`
but not for `python@3.7`.

The patch directive should be surrounded by an `if Hardware::CPU.arm?`
block.
claui pushed a commit to xvilo/homebrew-core that referenced this pull request Jul 15, 2020
This replaces the three unmerged PR patches with a hosted
formula patch.

This includes the following upstream pull requests:

- python/cpython#20171, "Fix _tkinter use" (prerequisite for 21249)
- python/cpython#21114, "Support arm64 in Mac/Tools/pythonw"
- python/cpython#21224, "allow python to build for macosx-11.0-arm64"
- python/cpython#21249, "ctypes fixes for arm64 Mac OS"

See also:

- Homebrew/formula-patches#292
BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Jul 16, 2020
This replaces the three unmerged PR patches with a hosted
formula patch.

This includes the following upstream pull requests:

- python/cpython#20171, "Fix _tkinter use" (prerequisite for 21249)
- python/cpython#21114, "Support arm64 in Mac/Tools/pythonw"
- python/cpython#21224, "allow python to build for macosx-11.0-arm64"
- python/cpython#21249, "ctypes fixes for arm64 Mac OS"

See also:

- Homebrew/formula-patches#292

Closes #57997.

Signed-off-by: Claudia Pellegrino <1239874+claui@users.noreply.github.com>
@ned-deily
Copy link
Member

Thanks for the PR. It has been included in and superseded by GH-22855,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants