python@3: add arm64 compatibility patches #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This set of patches includes the following upstream pull requests: - PR #21114, "Support `arm64` in Mac/Tools/pythonw" python/cpython#21114 - PR #21224, "allow python to build for macosx-11.0-arm64" python/cpython#21224 - PR #21249, "ctypes fixes for arm64 Mac OS" python/cpython#21249 Adding them here is warranted as `python@3.8` is widely used as a dependency, and the patch is required to enable testing dependent formulae. Note that these have been successfully tested for `python@3.8` but not for `python`. The patch directives should be surrounded by an `if Hardware::CPU.arm?` block.
|
Why not reference the upstream pull requests in our formulae? |
|
@SMillerDev They’re still under review upstream, and may therefore change unexpectedly, causing spurious SHA failures. No strong opinion on that though. Happy to reference them directly if that’s ok for us. |
|
Closing in favour of applying individual PR commits directly. |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of patches includes the following upstream pull requests:
arm64in Mac/Tools/pythonw"Adding them here is warranted as
python@3.8is widely used as a dependency, and the patch is required to enable testing dependent formulae.Note that these have been successfully tested for
python@3.8but not forpython.The patch directives should be surrounded by an
if Hardware::CPU.arm?block.