python@3.8: add arm64 compatibility patches #57425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This set of patches includes the following upstream pull requests: - python/cpython#21114 "Support `arm64` in Mac/Tools/pythonw" - python/cpython#21224 "allow python to build for macosx-11.0-arm64" - python/cpython#21249 "ctypes fixes for arm64 Mac OS" Adding the patches before upstream has released them is warranted here because `python@3.8` is widely used as a dependency, and the patch is needed to enable testing dependent formulae on arm64. CC: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com>
9 tasks
|
I think building x86_64 bottles for this PR is unnecessary, since it is a change for ARM. So I would propose cancelling the jobs and just merge it via UI, to not occupy the runners. |
|
@dawidd6 Good point. Workflow cancelled. |
|
Merged, thanks @claui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?This set of patches includes the following upstream pull requests:
arm64in Mac/Tools/pythonw"Adding the patches before upstream has released them is warranted here because
python@3.8is widely used as a dependency, and the patches are needed to enable testing dependent formulae on arm64.Supersedes Homebrew/formula-patches#287.