-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.6 and 3.7 which are past end of life upstream #23
Conversation
7a58c82
to
1ef687a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 94.16% 93.97% -0.19%
==========================================
Files 18 18
Lines 548 548
Branches 106 106
==========================================
- Hits 516 515 -1
Misses 23 23
- Partials 9 10 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1ef687a
to
89b7034
Compare
@stdedos I think it could be merged even with the negative coverage change. |
89b7034
to
bc95dc1
Compare
@stdedos could you review this, please :) ? The CI is red because of an indirect coverage changes that I think we can ignore. |
Yeah, this seems to be the problem: I'd be nice to figure out why is this happening, but it is definitely not a priority - given the benefits of this PR. "I am not reviewing this" since it's not scheduled to go in yet. Plan is:
Question:
|
Co-authored-by: Irtaza Akram <irtaza.akram@arbisoft.com>
fd067e9
to
65fa52b
Compare
Hey, I tried dropping the removal of python 3.6 / 3.7 and simply adding python 3.12, but this is non trivial (https://github.com/pylint-dev/pylint-pytest/actions/runs/7010519218/job/19071209667?pr=24). It's been nearly two months since the release of python 3.12 / pylint 3.0 and python 3.6 / 3.7 have been EOL for a long time, maybe we could just drop EOL interpreters and release 2.X serie, what do you think ? |
See this issue in vscode/pylint : microsoft/vscode-pylint#460 for example |
Thank you for trying ❤️ Sadly, my OSS time has been near-zero these days. |
No problem. This one is ready the coverage drop is acceptable imo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must be merged after #27, if it becomes ready for a Monday release
I took the liberty to prepare this for tomorrow 🙃 |
* master: Update/Prepare Changelog for v1.1.7 use pylint v3 in the repo remove support of pylint v1 Support pylint v3 Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com> Additionally, some minor format modifications at `CHANGELOG.md`
f1e6197
to
f6e9b9e
Compare
Thank you @stdedos :) |
Thank you @Pierre-Sassoulas for all your contributions and patience 😁 🙏 |
# Added * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Introduced @dependabot (part of #28) * Improved reliability of the `FixtureChecker` class (#29) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
# Added * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Introduced @dependabot (part of #28) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Improved reliability of the `FixtureChecker` class (#29) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
# Added * Increased reproducibility of the project, by using `pip-compile` for the development dependencies (#28, small bugfix in #39) * Introduced @dependabot (part of #28) # Removed * Support for Python 3.6 & 3.7 (#23) # Improved * Migrate setup.py to pyproject.toml (#8) * Support for Python 3.12 (#3, "side effect" of #8) * Improved reliability of the `FixtureChecker` class (#29) * Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c) Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Cherry-picked from #8, I'm doing things progressively so it's reviewable.
Closes #11