Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework dev dependencies management #28

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

anis-campos
Copy link

@anis-campos anis-campos commented Dec 3, 2023

this rework allows for a better dev dependency management.
now a simple make install shall provid the required dev environment for both CI and local dev.
using a dev-requirement.txt files ensures repeatability and consistency between CI runs and local dev.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f559398) 93.98% compared to head (bb07434) 93.98%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   93.98%   93.98%           
=======================================
  Files          18       18           
  Lines         549      549           
  Branches      106      106           
=======================================
  Hits          516      516           
  Misses         23       23           
  Partials       10       10           
Flag Coverage Δ
3.10 93.98% <ø> (ø)
3.11 93.98% <ø> (ø)
3.12 93.98% <ø> (ø)
3.8 93.98% <ø> (ø)
3.9 93.98% <ø> (ø)
macos-latest 93.98% <ø> (ø)
ubuntu-latest 93.98% <ø> (ø)
windows-latest 93.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anis-campos anis-campos changed the title requirements rework dev dependencies management Dec 3, 2023
@anis-campos
Copy link
Author

🤔 , might be wise to pick some stuffs from #8, like dropping the setup.cfg in favour to the pyproject.yaml

Makefile Outdated Show resolved Hide resolved
dev-requirements.in Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@stdedos
Copy link
Collaborator

stdedos commented Dec 4, 2023

I apologize, there were a couple of issues with origin/master
I resolved them, but that involved a force-push 😖

You'll probably need to update your base

@stdedos
Copy link
Collaborator

stdedos commented Dec 4, 2023

@anis-campos

🤔 , might be wise to pick some stuffs from #8, like dropping the setup.cfg in favour to the pyproject.yaml

Should I just pile #8 on master?

@anis-campos
Copy link
Author

anis-campos commented Dec 4, 2023

@anis-campos

🤔 , might be wise to pick some stuffs from #8, like dropping the setup.cfg in favour to the pyproject.yaml

Should I just pile #8 on master?

If it is ready, go for it, we can rebase this branch just fine afterwards.

@anis-campos anis-campos force-pushed the requirements branch 3 times, most recently from b8826ff to 2462e0f Compare December 4, 2023 20:44
@stdedos stdedos added this to the Release v2 milestone Dec 19, 2023
@stdedos
Copy link
Collaborator

stdedos commented Dec 19, 2023

After a long wait, #8 was merged! 🎉 🎉 🎉 🎉 🎉

@anis-campos
Copy link
Author

After a long wait, #8 was merged! 🎉 🎉 🎉 🎉 🎉

Perfect, so let's rebase this one then.

this rework allows for a better dev dependency management.
now a simple `make install` shall provid the required dev environment for both CI and local dev.
using a dev-requirement.txt files ensures repeatability and consistency between CI runs and local dev.
.DS_Store Outdated Show resolved Hide resolved
@stdedos stdedos force-pushed the requirements branch 2 times, most recently from f26a98d to 188b53f Compare December 20, 2023 09:38
Makefile Outdated Show resolved Hide resolved
@stdedos
Copy link
Collaborator

stdedos commented Dec 21, 2023

Okay, so - since the actions are passing, and you think this is a step forward - fine by me.

Can it now be updated easily, however? Can something pick this up? (Dependabot, Renovate, etc)

@anis-campos
Copy link
Author

anis-campos commented Dec 21, 2023

Okay, so - since the actions are passing, and you think this is a step forward - fine by me.

Can it now be updated easily, however? Can something pick this up? (Dependabot, Renovate, etc)

Not sur for the others, but Dependabot is very efficient in bumping packages in the requirement.txt files with pip-compile, we have been using it in our projects. see more at https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#pip-and-pip-compile

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Copy link
Collaborator

@stdedos stdedos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you! Let's see how this works.

Copy link
Collaborator

@stdedos stdedos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you! Let's see how this works.

@stdedos stdedos merged commit bb1a8de into pylint-dev:master Dec 22, 2023
20 checks passed
@anis-campos anis-campos deleted the requirements branch December 22, 2023 10:44
stdedos added a commit that referenced this pull request Feb 2, 2024
# Added

* Migrate setup.py to pyproject.toml (#8)
* Support for Python 3.12 (#3,
  "side effect" of #8)
* Introduced @dependabot (part of #28)
* Improved reliability of the `FixtureChecker` class (#29)

# Removed

* Support for Python 3.6 & 3.7 (#23)

# Improved

* Increased reproducibility of the project, by using `pip-compile` for the development dependencies
  (#28, small bugfix in #39)
* Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c)

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
stdedos added a commit that referenced this pull request Feb 2, 2024
# Added

* Increased reproducibility of the project, by using `pip-compile` for the development dependencies
  (#28, small bugfix in #39)
* Introduced @dependabot (part of #28)

# Removed

* Support for Python 3.6 & 3.7 (#23)

# Improved

* Migrate setup.py to pyproject.toml (#8)
* Support for Python 3.12 (#3,
  "side effect" of #8)
* Improved reliability of the `FixtureChecker` class (#29)
* Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c)

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
stdedos added a commit that referenced this pull request Feb 2, 2024
# Added

* Increased reproducibility of the project, by using `pip-compile` for the development dependencies
  (#28, small bugfix in #39)
* Introduced @dependabot (part of #28)

# Removed

* Support for Python 3.6 & 3.7 (#23)

# Improved

* Migrate setup.py to pyproject.toml (#8)
* Support for Python 3.12 (#3,
  "side effect" of #8)
* Improved reliability of the `FixtureChecker` class (#29)
* Minor CI + License updates (in 29f0c33, e0e529a, 8f56d1c)

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants