-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for pylint 3 & python 3.12 #22
Conversation
Hi @stdedos, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 92.03% 91.96% -0.07%
==========================================
Files 18 18
Lines 527 523 -4
Branches 99 99
==========================================
- Hits 485 481 -4
Misses 29 29
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
The v2.0 I'm estimating to be released mid-November Setting this as blocked |
For the failing actions, you might want to revert b3e8974 |
Hi @stdedos, |
Thank you for offering the code @irtazaakram ❤️ |
hi @stdedos, |
🤦🏻 let me know if i should open a new PR? as I am also not able to reopen it. |
I think it should be something obvious we are both missing Also, GitHub is somewhat too magic sometimes for my taste 😅 |
Hey @irtazaakram pre-commit says this:
You'd have to either apply the changes, or allow pre-commit to apply those changes 😕 |
These changes causes tests to fail for python 3.8 & 3.9 |
I will eventually handle some of those pylint issues |
The MR looks solid - and we need to figure out a solution for Windows-testing. Amazing job @irtazaakram 🚀 |
I can't write directly on this branch but the fix for pylint's check is this: 904e2e9 |
Closing in favor of two other merge requests: #23 then #24. Thank you for your work @irtazaakram I credited you in the rebased commit. |
Hi,
This PR
Can we please have a new release after this PR is merged.
Thanks,
Fixes #11
Fixes #12