Numpy 1.13 for rtd #1957
Closed
Numpy 1.13 for rtd #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general it's easier to test the RTD config on the fix-docs branch, which is built on RTD. I took the liberty to push the environment.yml changes to it, and noticed a first conflict: https://readthedocs.org/projects/xray/builds/6834755/ If you don't mind I'll try to get rid of the conflicts and you can remove this part from your PR |
|
Also your branch seems a bit outdated, the changes shown by github are not accurate |
|
After #1958 , the new environment should be fine now: http://xarray.pydata.org/en/fix-docs/computation.html#missing-values |
|
Thanks, @fmaussion ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this is due to the use of old numpy on rtd.
xref #1956