Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy 1.11 support for apply_ufunc #1956

Closed
fujiisoup opened this issue Mar 3, 2018 · 1 comment
Closed

numpy 1.11 support for apply_ufunc #1956

fujiisoup opened this issue Mar 3, 2018 · 1 comment

Comments

@fujiisoup
Copy link
Member

I noticed the failing in rtd
http://xarray.pydata.org/en/stable/computation.html#missing-values
is because it still uses numpy=1.11 which does not support signature argument for np.vectorize.

This can be easily fixed (just bumping up numpy's version on rtd),
but as our minimum requirement is numpy==1.11, we may need to take care of this in xr.apply_ufunc.

@fujiisoup fujiisoup mentioned this issue Mar 3, 2018
1 task
@shoyer
Copy link
Member

shoyer commented Mar 4, 2018

I think we should just add an better error message about a newer version of NumPy being required. Backporting the changes to np.vectorize would also be pretty easy (see numpy/numpy#8054).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants