Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc for missing values. #1950

Merged
merged 3 commits into from
Mar 2, 2018
Merged

Fix doc for missing values. #1950

merged 3 commits into from
Mar 2, 2018

Conversation

fujiisoup
Copy link
Member

fujiisoup
fujiisoup commented Mar 2, 2018
View reviewed changes
doc/api.rst
Dataset.bfill
Dataset.interpolate_na
Dataset.where

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice if we could see docstrings for these methods in rtd.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, but these should be removed from api-hidden.rst now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@fujiisoup
Copy link
Member Author

fujiisoup commented Mar 2, 2018 •
edited
Loading

I'm wondering this can safely update docs on rtd because it is some commits ahead of the stable (e.g. it has docs about rolling.construct).
Should I start from the stable branch?

@shoyer shoyer merged commit 350e977 into pydata:master Mar 2, 2018
@shoyer
Copy link
Member

shoyer commented Mar 2, 2018

@fujiisoup What I do for updating the stable docs is to cherry-pick commits with doc fixes to the stable branch. As long as those apply cleanly (which is usually the case) we can update the stable docs.

@fujiisoup fujiisoup deleted the fix_doc branch March 3, 2018 00:34
shoyer pushed a commit that referenced this pull request Mar 3, 2018
@fujiisoup @shoyer
Fix doc for missing values. (#1950)
779fb27 
* Fix doc for missing values.

* Remove some methods from api-hidden

* Fix for dask page.
@shoyer
Copy link
Member

shoyer commented Mar 3, 2018

I just cherry-picked the merge commit from this PR into stable. So RTD should automatically update when the build finishes in ~15 minutes.

@fujiisoup
Copy link
Member Author

Thanks, @shoyer

But this part
http://xarray.pydata.org/en/stable/computation.html#missing-values
is still failing (I think this was working on my environment).
Is there any missing dependencies on rtd?

@fujiisoup fujiisoup mentioned this pull request Mar 3, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fujiisoup @shoyer