Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release v24.1 #3780

Merged
merged 773 commits into from
Jan 31, 2024
Merged

Make release v24.1 #3780

merged 773 commits into from
Jan 31, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Check the release workflow

agriyakhetarpal and others added 30 commits November 27, 2023 14:22
Move ruff, coverage, and pytest configs to pyproject.toml
Fixes doctests error
Sync lower bounds with conda package
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
agriyakhetarpal and others added 9 commits January 16, 2024 19:49
* Ensure correct Python versions for Jax solver compatibility

* Simplify array of Python versions

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* Use different conjunction

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Make `pybamm_install_odes` a bit more robust
* #3690 fix issue with skipped steps

* #3690 changelog

* #3690 add test
* #3611 use actual cell volume for average total heating

* #3611 changelog

* #3611 account for number of electrode pairs

* #3611 update variable names
* Try fixing the release workflow

* Turn off safety

* Fix CHANGELOG

* Add OS

* Use regex for better matches

* Update instructions, add safety checks

* checkout to the version branch for the final release
* #3630 fix interpolant shape error

* #3630 changelog
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Saransh-cpp Saransh-cpp requested review from a team January 29, 2024 23:11
@Saransh-cpp Saransh-cpp linked an issue Jan 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e00b0d5) 99.58% compared to head (e29dcc0) 99.59%.
Report is 6 commits behind head on main.

Files Patch % Lines
pybamm/models/submodels/thermal/base_thermal.py 95.55% 2 Missing ⚠️
...bamm/expression_tree/operations/evaluate_python.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3780    +/-   ##
========================================
  Coverage   99.58%   99.59%            
========================================
  Files         256      258     +2     
  Lines       20106    20813   +707     
========================================
+ Hits        20023    20728   +705     
- Misses         83       85     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kratman
kratman previously approved these changes Jan 29, 2024
Copy link
Contributor

@kratman kratman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming all the commits are correct

@kratman kratman dismissed their stale review January 29, 2024 23:31

Mac builds are failing

agriyakhetarpal and others added 2 commits January 30, 2024 19:53
…nner (#3785)

* Try fixing M-series runner tests

This is being done by adding SuiteSparse and SUNDIALS installations which might have been missing on the runner, which broke `scikits.odes`.

* Don't use Homebrew SUNDIALS, use LD_LIBRARY_PATH

* Don't use Homebrew to install SUNDIALS

* Force remove pip cache for `scikits.odes`

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing doctest warning regarding parallel builds has been fixed in the develop branch. It should be safe to merge this.

@Saransh-cpp Saransh-cpp merged commit bb6fc9b into main Jan 31, 2024
63 of 70 checks passed
@Saransh-cpp Saransh-cpp deleted the v24.1 branch January 31, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create 24.01 (final or rc0) release