Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml to the project #3053

Closed
wants to merge 9 commits into from

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Jun 20, 2023

Description

This PR adds pyproject.toml to keep project up to date & also potentially handle PyBaMM packaging to further have pybamm[all] installation.

Note : This is subjected based on the complexity of this issue, I haven't done this before but will try my best to complete this PR with your help definitely.
Fixes #3049

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@arjxn-py
Copy link
Member Author

Also directly related to #3035

@arjxn-py arjxn-py force-pushed the add-pyproject.toml branch from c203aac to e742f51 Compare June 21, 2023 08:33
@arjxn-py
Copy link
Member Author

arjxn-py commented Jun 21, 2023

CMakeBuild error solved by using legacy here

@arjxn-py arjxn-py force-pushed the add-pyproject.toml branch from ad6f922 to cbc8583 Compare June 21, 2023 08:52
@arjxn-py
Copy link
Member Author

Getting these logs which i was also getting while using tox4 hence trying using nox here as #3005 is not merged yet.

@arjxn-py arjxn-py marked this pull request as draft June 23, 2023 07:00
@arjxn-py arjxn-py closed this Sep 23, 2023
@arjxn-py arjxn-py deleted the add-pyproject.toml branch February 21, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate or conjugate pyproject.toml with setup.py
1 participant