Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate or conjugate pyproject.toml with setup.py #3049

Closed
arjxn-py opened this issue Jun 19, 2023 · 0 comments · Fixed by #3301
Closed

Migrate or conjugate pyproject.toml with setup.py #3049

arjxn-py opened this issue Jun 19, 2023 · 0 comments · Fixed by #3301
Assignees
@agriyakhetarpal
Labels
difficulty: hard Will take several weeks priority: medium To be resolved if time allows

Comments

@arjxn-py
Copy link
Member

This issue aims to discuss & integrate pyproject.toml into the project introduced in PEP 518 to handle builds & pypi packaging.
@arjxn-py arjxn-py mentioned this issue Jun 20, 2023
Closed
8 tasks
@Saransh-cpp Saransh-cpp added difficulty: hard Will take several weeks priority: medium To be resolved if time allows labels Jun 28, 2023
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 30, 2023
@agriyakhetarpal
pybamm-team#3049 initial draft: metadata, dependencies, extras, entry…
7d4c8cf 
… points
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 30, 2023
@agriyakhetarpal
pybamm-team#3049 Fix LICENSE spelling
aca9a6a
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 30, 2023
@agriyakhetarpal
pybamm-team#3049 Temporarily build wheels on pull requests
3af5092
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 30, 2023
@agriyakhetarpal
pybamm-team#3049 Add CMakeBuild steps to setup.py instead of import…
8768ed7 
…ing it
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 30, 2023
@agriyakhetarpal
pybamm-team#3049 Temporarily install casadi before installing editable
66e9302
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 30, 2023
@agriyakhetarpal
pybamm-team#3049 Better error message if casadi path is not found
8b6a184
@agriyakhetarpal agriyakhetarpal mentioned this issue Aug 30, 2023
Merged
14 tasks
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 30, 2023
@agriyakhetarpal
pybamm-team#3049 Rename wheel build workflow name
3bec0ba
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 30, 2023
@agriyakhetarpal
pybamm-team#3049 Temporarily use --no-build-isolation in CI
bfafc75
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 30, 2023
@agriyakhetarpal
pybamm-team#3049 add cmake to build-system requirements
f4d148a
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 30, 2023
@agriyakhetarpal
Revert "pybamm-team#3049 add cmake to build-system requirements"
60caf0b 
This reverts commit f4d148a.
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 31, 2023
@agriyakhetarpal
pybamm-team#3049 Clarify author emails
d8d6194
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 31, 2023
@agriyakhetarpal
pybamm-team#3049 clarify idaklu attributes (setuptools API)
bdd191e
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 31, 2023
@agriyakhetarpal
pybamm-team#3049 Specify casadi as a build-time dependency to overc…
9f0f250 
…ome venv isolated build error
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 31, 2023
@agriyakhetarpal
Revert "pybamm-team#3049 Temporarily use --no-build-isolation in CI"
1e480ee 
This reverts commit bfafc75.
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 31, 2023
@agriyakhetarpal
pybamm-team#3049 Remove casadi installation prior to editable
c2e2734 
This reverts commit 66e9302.
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 31, 2023
@agriyakhetarpal
pybamm-team#3049 specify cmake, fix casadi build-time requirements
2cd36af
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 31, 2023
@agriyakhetarpal
pybamm-team#3049 Fix doctests, trigger example notebook tests
0cdfd5a
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 31, 2023
@agriyakhetarpal
pybamm-team#3049 Remove non-colour nox output in the CI
fc222ca
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 31, 2023
@agriyakhetarpal
pybamm-team#3049 Force colour output on GitHub Actions
5cfc07a
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Aug 31, 2023
@agriyakhetarpal
pybamm-team#3049 Remove inessential editable install job in favour of…
82197eb 
… `nox`
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Sep 2, 2023
@agriyakhetarpal
pybamm-team#3049 Remove improper CMake message, add for macOS
13ed52d
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Sep 2, 2023
@agriyakhetarpal
pybamm-team#3049 Fix installation link
24fbb8f
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Sep 2, 2023
@agriyakhetarpal
pybamm-team#3049 Remove casadi rpath fix because its shared object ca…
2561a6e 
…nnot be found
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Sep 3, 2023
@agriyakhetarpal
pybamm-team#3049 Remove cmake from macOS in CI
921010e
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Sep 3, 2023
@agriyakhetarpal
Revert "pybamm-team#3049 Remove casadi rpath fix because its shared o…
1ee48c1 
…bject cannot be found"

This reverts commit 2561a6e.
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Sep 3, 2023
@agriyakhetarpal
pybamm-team#3049 Fix macOS universal ABI and platform wheels creation…
e4ea199 
… bug
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 fix LD_LIBRARY_PATH for nox
92f8940
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 remove Linux rpath fix script
c90529d
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 Add MSMR parameters entry point
2f6ada4
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 some installation cleanups (nox)
d8a7cfe
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 pybamm-team#3121 sync jax, jaxlib version requirements
ef9fb06
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 Improve docs about project installation infrastructure
e4c69ba
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 Update cache hashes to include nox changes
dd07a62
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 Fix UNKNOWN name error on SDist
04bd1f3 
See pypa/setuptools#3269 for more details
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 keep solvers extras in sync, don't install yanked ve…
34be757 
…rsions
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 Fix up authors name and email in project
3030c52
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 try to bump pybind11, vcpkg versions (Windows)
fa81e2d
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 add OKane2022 parameter entry points
12e6426
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 correctly specify inclusion of packages
aceb478
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 Remove unneeded files (used for old manylinux)
51273c1 
Not needed anymore after we have been using `cibuildwheel`, which uses the Dockerfile from PyPA
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 move SUNDIALS installation to scripts/
f3c9dca
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 delete older SUNDIALS CMake files
027758f 
these were used for finding KLU earlier but are for now outdated versions of SUNDIALS (<6). We currently use a custom vcpkg registry which comes with modified portfiles for this purpose.
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 add pyproject.toml to release workflows
eb14674
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 remove setup.py as CI cache dependency path
23af6b2
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 add note about new file to manage deps
2bf363d
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 clarify usage of cmake and casadi
1427db3 
In the build-time requirements for Windows, we don't use cmake and casadi from pip, but from other sources. This is because we use Visual Studio to compile.
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 update version to 23.9rc0
170f875
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 make cmake a bit verbose about sundials and suitesparse
4b6221d
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @Saransh-cpp @js1tr3
pybamm-team#3049 add suggestions from code review
277c853 
Co-Authored-By: Saransh Chopra <saransh0701@gmail.com>
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 clarify extension language
20424d8
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @Saransh-cpp @js1tr3
pybamm-team#3049 include citation file in source distribution
d052dfa 
Co-Authored-By: Saransh Chopra <saransh0701@gmail.com>
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @Saransh-cpp @js1tr3
pybamm-team#3049 remove note about requirements.txt
597485f 
Co-Authored-By: Saransh Chopra <saransh0701@gmail.com>
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @Saransh-cpp @js1tr3
pybamm-team#3049 fix docs indentation
9a9cdc2 
Co-Authored-By: Saransh Chopra <saransh0701@gmail.com>
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @Saransh-cpp @js1tr3
pybamm-team#3049 specify lower bounds for setuptools
602fec1 
Co-Authored-By: Saransh Chopra <saransh0701@gmail.com>
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @js1tr3
pybamm-team#3049 cleanup and clarify user installation page
f0872e1
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@agriyakhetarpal @kratman @js1tr3
pybamm-team#3049 code review suggestions from Eric
0f1c15b 
do not install gcc or gfortran if they are already installed, just reinstall them

Co-Authored-By: Eric G. Kratz <kratman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agriyakhetarpal agriyakhetarpal

Labels
difficulty: hard Will take several weeks priority: medium To be resolved if time allows
Projects
None yet
Milestone
No milestone
3 participants
@Saransh-cpp @agriyakhetarpal @arjxn-py