-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting the required dependencies into optional dependencies #3035
Comments
Related to #2457 |
Discussion from today's meeting -
Maintainers can iteratively add here the dependencies which they think can be made optional. |
The following dependencies can be made optional without affecting 95% of functionality:
|
The dependency graph with |
How should I go with grouping them further or should we have a single tag say |
About pandas, I think the trickiest point will be that some parameter sets won't work without pandas (they use Just to clarify, I am not against pandas being optional, but I think it would be good to keep all parameters working with the basic PyBaMM. |
Please feel free to update this. We'll also need documentation on this so this can be worked upon in multiple PRs. EasyShould be straight forward and we do want them to be optional.
ModerateMight require some work but we still might want them to be optional.
HardWe might not even want to change their status and keep them as the required ones.
Keep as required
|
For pandas we could set the default to use the equivalent numpy function and then we would not need pandas I would actually put tqdm and bpx in the easy bucket too For the hard ones:
|
There should be smaller groups, like |
I really like the way pandas handles and documents optional dependencies: https://pandas.pydata.org/docs/getting_started/install.html#optional-dependencies So I'm not sure whether zsh handles square brackets so we might need to encourage using quotes e.g. |
Pandas handles this type of installation using |
You don't necessarily need |
Description
Currently pybamm is installing many dependencies we want to have a lite version of pybamm by splitting the required deps into optional deps
The text was updated successfully, but these errors were encountered: