Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: 5.0.0 #2851

Merged
merged 8 commits into from
Sep 17, 2024
Merged

REL: 5.0.0 #2851

merged 8 commits into from
Sep 17, 2024

Conversation

pubpub-zz
Copy link
Collaborator

@pubpub-zz pubpub-zz commented Sep 15, 2024

Version 5.0.0, 2024-09-15

This release drops support to Python 3.7 and introduces the capability to build incremental PDF files.

Security (SEC)

New Features (ENH)

Bug Fixes (BUG)

Robustness (ROB)

Documentation (DOC)

Developer Experience (DEV)

Maintenance (MAINT)

Code Style (STY)

Other

Full Changelog

Release version 5.0.0
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (8eefba8) to head (159fd25).
Report is 90 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2851   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          51       51           
  Lines        8501     8501           
  Branches     1696     1696           
=======================================
  Hits         8160     8160           
  Misses        200      200           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@stefan6419846 stefan6419846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reduce the changelog to omit unimportant changes and fix line 15 to match the other lines. (Please note that this has to be done for the merge commit data as well.) Additionally, I slightly adjusted the wording of the introductory text which should be transferred as well.

If you need help, feel free to come back to me and I will have a look at condensing the changelog myself tomorrow.

@MartinThoma
Copy link
Member

@pubpub-zz @stefan6419846 Thank you for keeping pypdf alive 🙏

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@pubpub-zz
Copy link
Collaborator Author

@stefan6419846
Is it ok now ?

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Martin Thoma <info@martin-thoma.de>
MartinThoma
MartinThoma previously approved these changes Sep 15, 2024
Copy link
Member

@MartinThoma MartinThoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉 Thank you 🙏

As I'm out of touch of recent developments it would be good to wait for the approval of @stefan6419846

Makefile Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@stefan6419846
Copy link
Collaborator

I have just reverted all the unrelated changes to the files. They need further dedicated discussions.

Copy link
Collaborator

@stefan6419846 stefan6419846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be okay now. Please ensure that the merge commit uses the correct (cleaned up) message. Creating the tag will probably need manual tasks as well.

@pubpub-zz pubpub-zz merged commit 637bc44 into py-pdf:main Sep 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants