Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove b_ and str_ #2792

Merged
merged 9 commits into from
Aug 12, 2024
Merged

MAINT: Remove b_ and str_ #2792

merged 9 commits into from
Aug 12, 2024

Conversation

pubpub-zz
Copy link
Collaborator

closes #2726
superseed proposal #2791

@stefan6419846
Copy link
Collaborator

Could you please provide some further rationale for this change?

@pubpub-zz pubpub-zz changed the title MNT: Remove b_ and str_ MAINT: Remove b_ and str_ Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (5abd590) to head (6eeac53).
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2792      +/-   ##
==========================================
+ Coverage   95.16%   95.26%   +0.09%     
==========================================
  Files          51       51              
  Lines        8545     8535      -10     
  Branches     1703     1700       -3     
==========================================
- Hits         8132     8131       -1     
+ Misses        261      252       -9     
  Partials      152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Collaborator Author

after analysis, most of the b_ were required due to StreamObjects. I've fixed the cases where a string was generated instead of bytes. some operators from operations were inserted as text instead of string.I've also refactored some functions to try to improve performances.
read_string_from_stream was partially rewritten. now the r"c:\DEB\3368" is converted into b"c:\DEB\3368" instead of "C:DEBÆł8". This is for me another way to interprete pypdf spec 1.7 p54. and which I currently prefer
The change in expected file Seige_of_Vicksburg_Sample_OCR-crazyones-merged.pdf is a space which is written as " " instead of \040 (which is the octal code of 32)

there is still a little of work for coverage (under analysis) but @stefan6419846 / @j-t-1 waiting for your comments

@j-t-1
Copy link
Contributor

j-t-1 commented Aug 9, 2024

This is a win. These kinds of improvements make pypdf more readable, understandable and extensible.

@pubpub-zz
Copy link
Collaborator Author

pubpub-zz commented Aug 9, 2024

test coverage is good now.

@pubpub-zz pubpub-zz requested a review from stefan6419846 August 9, 2024 08:04
pypdf/_cmap.py Outdated Show resolved Hide resolved
@stefan6419846 stefan6419846 merged commit 46c89dd into py-pdf:main Aug 12, 2024
17 checks passed
@pubpub-zz pubpub-zz mentioned this pull request Sep 15, 2024
kmurphy4 added a commit to kmurphy4/pypdf that referenced this pull request Nov 13, 2024
kmurphy4 added a commit to kmurphy4/pypdf that referenced this pull request Nov 13, 2024
kmurphy4 added a commit to kmurphy4/pypdf that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functionality of b_
4 participants