Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Small changes to PaperSize notes #2834

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Sep 5, 2024

Plus one typo in xmp.py.

Plus one typo in xmp.py.
@j-t-1
Copy link
Contributor Author

j-t-1 commented Sep 5, 2024

This could also be amended, but unsure how to do so:

# Additionally, A0 is defined to have an area of 1 m**2

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (e694d55) to head (b9ef7fd).
Report is 98 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2834   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          51       51           
  Lines        8576     8576           
  Branches     1696     1696           
=======================================
  Hits         8223     8223           
  Misses        210      210           
  Partials      143      143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pubpub-zz
pubpub-zz previously approved these changes Sep 5, 2024
@pubpub-zz
Copy link
Collaborator

This could also be amended, but unsure how to do so:

# Additionally, A0 is defined to have an area of 1 m**2

what about adding link to https://en.wikipedia.org/wiki/ISO_216

@j-t-1
Copy link
Contributor Author

j-t-1 commented Sep 5, 2024

This could also be amended, but unsure how to do so:
# Additionally, A0 is defined to have an area of 1 m**2

what about adding link to https://en.wikipedia.org/wiki/ISO_216

Good idea; done.

@stefan6419846
Copy link
Collaborator

It seems like the last commit did not went through?

Plus one typo in xmp.py.
@stefan6419846 stefan6419846 merged commit b85c171 into py-pdf:main Sep 6, 2024
16 checks passed
@j-t-1 j-t-1 deleted the papersizes branch September 6, 2024 10:12
@pubpub-zz pubpub-zz mentioned this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants