Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis Fixes #8074

Closed
wants to merge 4 commits into from
Closed

Travis Fixes #8074

wants to merge 4 commits into from

Conversation

cesswairimu
Copy link
Collaborator

Check if travis passes

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@cesswairimu cesswairimu changed the title Dummy PR Travis Fixes Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #8074 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8074   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files          99       99           
  Lines        5737     5737           
=======================================
  Hits         4728     4728           
  Misses       1009     1009           
Impacted Files Coverage Δ
app/controllers/tag_controller.rb 81.40% <100.00%> (ø)

@cesswairimu cesswairimu reopened this Jun 24, 2020
This was referenced Jun 25, 2020
@Tlazypanda
Copy link
Collaborator

@cesswairimu I tried fixing it here can you check out #8085 Thanks ✌️

@cesswairimu
Copy link
Collaborator Author

cesswairimu commented Jun 26, 2020

@Tlazypanda I rebased this and seems like its taking longer... been running for an hour now.. also it looks like tests are not being ran on travis now...did we remove those from your PR that I just merged?

@Tlazypanda Tlazypanda closed this Jun 26, 2020
@Tlazypanda Tlazypanda reopened this Jun 26, 2020
@Tlazypanda
Copy link
Collaborator

Tlazypanda commented Jun 26, 2020

Hey @cesswairimu I actually reopened for one of my other prs #8076 and then it passed 😅 let us try this for this one as well 😅 if that's not an issue

Edit: yay!! it is passing now

@cesswairimu
Copy link
Collaborator Author

Fantastic thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants