-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis Fixes #8074
Travis Fixes #8074
Conversation
78c5268
to
aeaaff2
Compare
Codecov Report
@@ Coverage Diff @@
## master #8074 +/- ##
=======================================
Coverage 82.41% 82.41%
=======================================
Files 99 99
Lines 5737 5737
=======================================
Hits 4728 4728
Misses 1009 1009
|
@cesswairimu I tried fixing it here can you check out #8085 Thanks ✌️ |
7c52306
to
5ff942a
Compare
@Tlazypanda I rebased this and seems like its taking longer... been running for an hour now.. also it looks like tests are not being ran on travis now...did we remove those from your PR that I just merged? |
Hey @cesswairimu I actually reopened for one of my other prs #8076 and then it passed 😅 let us try this for this one as well 😅 if that's not an issue Edit: yay!! it is passing now |
Fantastic thanks 👍 |
Check if travis passes
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!