-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spam2: pagination added #8063
Spam2: pagination added #8063
Conversation
app/assets/javascripts/spam2.js
Outdated
@@ -11,7 +11,12 @@ function table_main(id) { | |||
"search": { | |||
"regex": true | |||
}, | |||
"scrollX": true | |||
"scrollX": true, | |||
"paging":false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please format JS properly (with a tool)?
Thanks, @keshavsethi.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya Sure, Thanks!
Codecov Report
@@ Coverage Diff @@
## master #8063 +/- ##
==========================================
+ Coverage 82.41% 82.53% +0.12%
==========================================
Files 99 99
Lines 5737 5737
==========================================
+ Hits 4728 4735 +7
+ Misses 1009 1002 -7
|
@jywarren I will customize pagination more in future PRs. Thanks!! |
Great, thank you!!! |
@jywarren I have divided nodes into a batch of 100 which means all nodes will be rendered in batches. we can use table filters and search and other bulk features within that batch. It will reduce load time without hindering any feature. I have also ordered nodes wrt time. For example, there are 1000 nodes then it will be divided into a batch of 100 so there are 10 batches in total. Within each batch, all filters and stats will work. There are few Screenshots Please review |
Hm, looks like tests didn't pass? Can you check what happened? Thanks! |
All four tests in Travis are failing
@jywarren, please help. I don't know why it is happening. Do I need to install some gems?? Tests are working fine locally. Thanks!! |
Yeah that is weird..trying to restart travis |
Hi @keshavsethi seems the build failed on master after the last merge...checking to see if I can get that fixed |
@cesswairimu @jywarren Thanks!! Should I close and reopen this PR?? |
Sure, you could try that...I opened a PR #8074 that I am trying to fix this error, no luck yet though |
@keshavsethi you can rebase or reopen this...the errors are fixed |
@jywarren @emilyashley @cesswairimu @pydevsg @VladimirMikulic @ananyaarun @Uzay-G Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Hi @VladimirMikulic, could you please give a final review when you get a minute against the changes you requested? Thanks |
- closed the `page-table` div
Great work @keshavsethi 🎉 |
This is awesome 🚀 thanks a lot everyone 🎉 🎉 🎉 |
Stable was taking too much time to render all data. So, here I used Will_Paginate which will divide data into pages. I will customize it more in future PRs. Please refer to the following Screenshot.
@jywarren @emilyashley @cesswairimu @pydevsg @VladimirMikulic Please review.
Thanks!